getSettings() is called exactly once at module load (const baseSettings = atom<Settings>(getSettings())) and setSettings serializes the entire settings object on every change. Unlike atomWithLocalStorage (src/app/state/utils/atomWithLocalStorage.ts:30-39), which does install a storage listener, the main settings atom has none. Two open tabs therefore each hold a snapshot from their own load time; whichever writes last silently reverts every setting the other tab changed since. This affects the largest settings surface in the app (theme, notifications, call/denoise, composer toolbar, translation).
How to trigger
open the app in two tabs. In tab A change the theme. In tab B toggle any unrelated setting. Reload tab A — the theme change is gone.
Suggested fix
give settingsAtom an onMountstorage listener keyed on 'settings' that re-reads via getSettings() (mirroring atomWithLocalStorage), or merge-on-write by re-reading the stored blob before setItem.
Filed from the September 2026 client audit (branch lotus @ 4bea4895).
**Severity:** medium · **Type:** bug · **Confidence:** high
**Location:** `src/app/state/settings.ts:379-455`
### Problem
`getSettings()` is called exactly once at module load (`const baseSettings = atom<Settings>(getSettings())`) and `setSettings` serializes the **entire** settings object on every change. Unlike `atomWithLocalStorage` (`src/app/state/utils/atomWithLocalStorage.ts:30-39`), which does install a `storage` listener, the main settings atom has none. Two open tabs therefore each hold a snapshot from their own load time; whichever writes last silently reverts every setting the other tab changed since. This affects the largest settings surface in the app (theme, notifications, call/denoise, composer toolbar, translation).
### How to trigger
open the app in two tabs. In tab A change the theme. In tab B toggle any unrelated setting. Reload tab A — the theme change is gone.
### Suggested fix
give `settingsAtom` an `onMount` `storage` listener keyed on `'settings'` that re-reads via `getSettings()` (mirroring `atomWithLocalStorage`), or merge-on-write by re-reading the stored blob before `setItem`.
---
_Filed from the September 2026 client audit (branch `lotus` @ 4bea4895)._
jared
added this to the Audit 2026-09 · Medium & Low milestone 2026-09-12 01:51:09 -04:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Severity: medium · Type: bug · Confidence: high
Location:
src/app/state/settings.ts:379-455Problem
getSettings()is called exactly once at module load (const baseSettings = atom<Settings>(getSettings())) andsetSettingsserializes the entire settings object on every change. UnlikeatomWithLocalStorage(src/app/state/utils/atomWithLocalStorage.ts:30-39), which does install astoragelistener, the main settings atom has none. Two open tabs therefore each hold a snapshot from their own load time; whichever writes last silently reverts every setting the other tab changed since. This affects the largest settings surface in the app (theme, notifications, call/denoise, composer toolbar, translation).How to trigger
open the app in two tabs. In tab A change the theme. In tab B toggle any unrelated setting. Reload tab A — the theme change is gone.
Suggested fix
give
settingsAtomanonMountstoragelistener keyed on'settings'that re-reads viagetSettings()(mirroringatomWithLocalStorage), or merge-on-write by re-reading the stored blob beforesetItem.Filed from the September 2026 client audit (branch
lotus@4bea4895).