Fixes#295. This is also the root cause of the "missed call from me" seen in voice channels.
CallEmbed asked Element Call to send a call-start notification for every non-DM call. In persistent voice channels and space rooms that notification carries an @room mention:
every member got a highlighted ping (and a phone push) whenever a moderator or admin joined first;
other clients showed it as a missed call.
Change
Only rooms that can ring (isRingableRoom: DMs, and invite-only groups outside a space) get ring / notification. Everything else passes sendNotificationType=none.
Pin @lotusguild/element-call-embedded0.25.0-lotus.23, which adds none (fork PR element-call#48).
Verified with the published 0.25.0-lotus.23, an admin joining the Voice Lounge:
Before:sendNotificationType=notification, and Bob got 1 new highlighted notification.
After:sendNotificationType=none, and Bob got none.
DMs still send ring; that logic is unchanged and covered by the isRingableRoom tests.
Fixes #295. This is also the root cause of the "missed call from me" seen in voice channels.
`CallEmbed` asked Element Call to send a call-start notification for **every** non-DM call. In persistent voice channels and space rooms that notification carries an **@room** mention:
- every member got a highlighted ping (and a phone push) whenever a moderator or admin joined first;
- other clients showed it as a missed call.
**Change**
- Only rooms that can ring (`isRingableRoom`: DMs, and invite-only groups outside a space) get `ring` / `notification`. Everything else passes `sendNotificationType=none`.
- Pin `@lotusguild/element-call-embedded` **0.25.0-lotus.23**, which adds `none` (fork PR element-call#48).
**Verified** with the published 0.25.0-lotus.23, an admin joining the Voice Lounge:
- **Before:** `sendNotificationType=notification`, and Bob got 1 new highlighted notification.
- **After:** `sendNotificationType=none`, and Bob got **none**.
DMs still send `ring`; that logic is unchanged and covered by the `isRingableRoom` tests.
`tsc` clean · unit tests pass · ESLint clean.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
CallEmbed asked Element Call to send a call-start notification for every
non-DM call. In persistent voice channels and space rooms it carries an
@room mention: every member got a highlighted ping (and phone push)
whenever a moderator or admin joined first, and other clients showed it
as a missed call. Now only rooms that can ring (isRingableRoom: DMs and
invite-only groups outside a space) get ring/notification; everything
else passes sendNotificationType=none (element-call-embedded 0.25.0-lotus.23).
Verified with a local build of the fork: an admin joining the Voice Lounge
sends none, and Bob gets no new notification (before: +1 highlighted).
Fixes#295
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Fixes #295. This is also the root cause of the "missed call from me" seen in voice channels.
CallEmbedasked Element Call to send a call-start notification for every non-DM call. In persistent voice channels and space rooms that notification carries an @room mention:Change
isRingableRoom: DMs, and invite-only groups outside a space) getring/notification. Everything else passessendNotificationType=none.@lotusguild/element-call-embedded0.25.0-lotus.23, which addsnone(fork PR element-call#48).Verified with the published 0.25.0-lotus.23, an admin joining the Voice Lounge:
sendNotificationType=notification, and Bob got 1 new highlighted notification.sendNotificationType=none, and Bob got none.DMs still send
ring; that logic is unchanged and covered by theisRingableRoomtests.tscclean · unit tests pass · ESLint clean.🤖 Generated with Claude Code
https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5