LotusGuild/cinny
3
0
Fork 0
Code Issues 27 Pull Requests 5 Actions Packages Projects Releases Wiki Activity

One click on the composer's globe icon posts your exact location to the room: no preview or confirm, accuracy ignored, shown to 5 decimals #340

New Issue
Closed
opened 2026-10-06 18:27:38 -04:00 by jared · 0 comments
jared commented 2026-10-06 18:27:38 -04:00
Owner
Copy Link
Copy Source

handleShareLocation (src/app/features/room/RoomInput.tsx:361-400, added in 86464f49) calls getCurrentPosition and sends the m.location event straight from the success callback. The browser asks for permission only once; after that a single click shares your position.

Measured (geolocation granted, position 40.748817, −73.985428, accuracy 3500 m):

  • One click on the 32×32 "Share location" button sent the event about 1 s later, with no dialog at any point: {"msgtype":"m.location","geo_uri":"geo:40.748817,-73.985428", …}.
  • The card renders "40.74882, -73.98543", which reads as exact to ~1 m, although the fix was ±3.5 km. pos.coords.accuracy is discarded.

Why this matters:

  • The button is on by default in every room (showLocation ?? true), including big public ones. It sits 36 px from its toolbar neighbours and its globe icon (Icons.SpaceGlobe) doesn't say "location", so it's easy to hit by accident.
  • On a laptop at home, "your location" is your home address. Redacting afterwards doesn't remove it from other people's clients, notifications, bridges or exports.
  • The opposite problem with inaccurate fixes: a Wi-Fi/IP fix shown to 5 decimals sends friends to the wrong place.

Fix:

  • Show a confirm step: a small map preview (click-to-load as in MLocation), the coordinates with "± N m", and Send / Cancel. Optionally offer "Send approximate (≈1 km)", which rounds to 2 decimals.
  • Include accuracy in the event as u= in the geo URI (RFC 5870, e.g. geo:40.7488,-73.9854;u=3500) so receivers can render a radius.
  • Show the location icon (Icons.Pin, already used in MLocation) instead of the globe.
  • Consider defaulting the toolbar button to hidden in rooms with more than ~50 members or public join rules.

Found in the October 2026 client audit (Playwright against a local Synapse + LiveKit stack, plus code reading). Code refs are at cinny 30e2dbcd, cinny-desktop 8f67ec7, element-call 3b0050e8.

`handleShareLocation` (src/app/features/room/RoomInput.tsx:361-400, added in 86464f49) calls `getCurrentPosition` and **sends the `m.location` event straight from the success callback**. The browser asks for permission only once; after that a single click shares your position. **Measured** (geolocation granted, position 40.748817, −73.985428, accuracy **3500 m**): - One click on the 32×32 "Share location" button sent the event about **1 s later**, with no dialog at any point: `{"msgtype":"m.location","geo_uri":"geo:40.748817,-73.985428", …}`. - The card renders **"40.74882, -73.98543"**, which reads as exact to ~1 m, although the fix was ±3.5 km. `pos.coords.accuracy` is discarded. **Why this matters:** - The button is on by default in every room (`showLocation ?? true`), including big public ones. It sits 36 px from its toolbar neighbours and its globe icon (`Icons.SpaceGlobe`) doesn't say "location", so it's easy to hit by accident. - On a laptop at home, "your location" is your home address. Redacting afterwards doesn't remove it from other people's clients, notifications, bridges or exports. - The opposite problem with inaccurate fixes: a Wi-Fi/IP fix shown to 5 decimals sends friends to the wrong place. **Fix:** - Show a confirm step: a small map preview (click-to-load as in `MLocation`), the coordinates with **"± N m"**, and *Send* / *Cancel*. Optionally offer "Send approximate (≈1 km)", which rounds to 2 decimals. - Include accuracy in the event as `u=` in the geo URI (RFC 5870, e.g. `geo:40.7488,-73.9854;u=3500`) so receivers can render a radius. - Show the location icon (`Icons.Pin`, already used in `MLocation`) instead of the globe. - Consider defaulting the toolbar button to hidden in rooms with more than ~50 members or public join rules. --- _Found in the October 2026 client audit (Playwright against a local Synapse + LiveKit stack, plus code reading). Code refs are at cinny `30e2dbcd`, cinny-desktop `8f67ec7`, element-call `3b0050e8`._
jared added the priority: mediumsecurityarea: messaging labels 2026-10-06 18:27:38 -04:00
jared closed this issue 2026-10-11 23:23:06 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
a11y
Accessibility: keyboard, screen reader, contrast, motion
 area: appearance
Client area: appearance
 area: auth-session
Client area: auth-session
 area: build-ci
Client area: build-ci
 area: calls
Client area: calls
 area: desktop
Client area: desktop
 area: media
Client area: media
 area: messaging
Client area: messaging
 area: mobile
Client area: mobile
 area: moderation
Client area: moderation
 area: navigation
Client area: navigation
 area: notifications
Client area: notifications
 area: settings
Client area: settings
 area: threads
Client area: threads
 bug
Something is not working
 dependencies
Third-party package versions and advisories
 docs
README / LOTUS_* docs wrong or missing
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 needs-human-review
performance
Re-render storms, leaks, heavy work on hot paths
 planning
priority: critical
Data loss, security hole, or crash on a main path
 priority: high
Broken feature or serious usability problem
 priority: low
Minor issue or polish
 priority: medium
Wrong behaviour in an edge case or notable degradation
 qa
Manual QA: shipped, needs a human in a real environment
 question
More information is needed
 research
security
XSS, unsafe URLs, data leaks, auth/session
 tech-debt
Code health, dead code, fragile patterns
 ux
Usability or visual inconsistency
 wontfix
This won't be fixed
No labels area: messaging priority: medium security
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
cole (Cole Keller) jared (Jared Vititoe) nathan (Nathan Vititoe)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: LotusGuild/cinny#340