LotusGuild/cinny
3
0
Fork 0
Code Issues 27 Pull Requests 5 Actions Packages Projects Releases Wiki Activity

"Rename for me" names aren't used by the quick switcher (Ctrl+K), forward/share pickers, search results, inbox or notifications #336

New Issue
Closed
opened 2026-10-05 23:50:31 -04:00 by jared · 1 comment
jared commented 2026-10-05 23:50:31 -04:00
Owner
Copy Link
Copy Source

The personal room name ("Rename for me", account data io.lotus.room_names, useLocalRoomName in src/app/hooks/useRoomMeta.ts) is applied in only five places: RoomNavItem, RoomViewHeader, Home, RoomIntro and CallRoomName. Everywhere else shows the server name.

Measured: general renamed to "Zebra Lounge". The sidebar and header show "Zebra Lounge" ✔. In Ctrl+K:

  • typing "Zebra" gives "No match found";
  • typing "general" finds it, displayed as "general".

These use room.name (from code; not each one clicked):

  • quick switcher: features/search/Search.tsx;
  • Forward dialog: ForwardMessageDialog.tsx; the Share page room list: pages/client/share/Share.tsx;
  • message search results and filters: SearchResultGroup.tsx, SearchFilters.tsx;
  • Inbox → Notifications: pages/client/inbox/Notifications.tsx;
  • the threads list header: ThreadsListPanel.tsx;
  • the in-app toast and OS notification title: ClientNonUIFeatures.tsx notify({ roomName: room.name });
  • the room-mention autocomplete.

People rename precisely the rooms whose real names are unhelpful ("!xyz", "Group with alice, bob…", a bridged channel name). Those are then the rooms they can't find with Ctrl+K, and the ones whose notifications show a name they don't recognise.

Fix: add a getDisplayRoomName(mx, room) helper (local name ?? room.name) and use it in those places. For the quick switcher, match on both names and show "Zebra Lounge · general".

Found in the October 2026 client audit (Playwright against a local Synapse + LiveKit stack, plus code reading). Code refs are at cinny 30e2dbcd, cinny-desktop 8f67ec7, element-call 3b0050e8.

The personal room name ("Rename for me", account data `io.lotus.room_names`, `useLocalRoomName` in src/app/hooks/useRoomMeta.ts) is applied in only five places: `RoomNavItem`, `RoomViewHeader`, `Home`, `RoomIntro` and `CallRoomName`. Everywhere else shows the server name. **Measured:** `general` renamed to **"Zebra Lounge"**. The sidebar and header show "Zebra Lounge" ✔. In **Ctrl+K**: - typing "Zebra" gives **"No match found"**; - typing "general" finds it, displayed as **"general"**. These use `room.name` (from code; not each one clicked): - quick switcher: `features/search/Search.tsx`; - **Forward** dialog: `ForwardMessageDialog.tsx`; the **Share** page room list: `pages/client/share/Share.tsx`; - message search results and filters: `SearchResultGroup.tsx`, `SearchFilters.tsx`; - Inbox → Notifications: `pages/client/inbox/Notifications.tsx`; - the threads list header: `ThreadsListPanel.tsx`; - the in-app toast and OS notification title: `ClientNonUIFeatures.tsx` `notify({ roomName: room.name })`; - the room-mention autocomplete. People rename precisely the rooms whose real names are unhelpful ("!xyz", "Group with alice, bob…", a bridged channel name). Those are then the rooms they can't find with Ctrl+K, and the ones whose notifications show a name they don't recognise. **Fix:** add a `getDisplayRoomName(mx, room)` helper (local name ?? `room.name`) and use it in those places. For the quick switcher, match on both names and show "Zebra Lounge · general". --- _Found in the October 2026 client audit (Playwright against a local Synapse + LiveKit stack, plus code reading). Code refs are at cinny `30e2dbcd`, cinny-desktop `8f67ec7`, element-call `3b0050e8`._
jared added the priority: lowuxarea: navigation labels 2026-10-05 23:50:31 -04:00
jared commented 2026-10-12 16:44:18 -04:00
Author
Owner
Copy Link
Copy Source

Mostly fixed by #359: Ctrl+K finds and shows the personal name, the Forward and Share pickers show and filter by it, and message and reminder notifications use it. Still open: message-search result headers, Inbox → Notifications and the threads list show the server name.

Mostly fixed by #359: Ctrl+K finds and shows the personal name, the Forward and Share pickers show and filter by it, and message and reminder notifications use it. Still open: message-search result headers, Inbox → Notifications and the threads list show the server name.
jared closed this issue 2026-10-16 22:12:55 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
a11y
Accessibility: keyboard, screen reader, contrast, motion
 area: appearance
Client area: appearance
 area: auth-session
Client area: auth-session
 area: build-ci
Client area: build-ci
 area: calls
Client area: calls
 area: desktop
Client area: desktop
 area: media
Client area: media
 area: messaging
Client area: messaging
 area: mobile
Client area: mobile
 area: moderation
Client area: moderation
 area: navigation
Client area: navigation
 area: notifications
Client area: notifications
 area: settings
Client area: settings
 area: threads
Client area: threads
 bug
Something is not working
 dependencies
Third-party package versions and advisories
 docs
README / LOTUS_* docs wrong or missing
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 needs-human-review
performance
Re-render storms, leaks, heavy work on hot paths
 planning
priority: critical
Data loss, security hole, or crash on a main path
 priority: high
Broken feature or serious usability problem
 priority: low
Minor issue or polish
 priority: medium
Wrong behaviour in an edge case or notable degradation
 qa
Manual QA: shipped, needs a human in a real environment
 question
More information is needed
 research
security
XSS, unsafe URLs, data leaks, auth/session
 tech-debt
Code health, dead code, fragile patterns
 ux
Usability or visual inconsistency
 wontfix
This won't be fixed
No labels area: navigation priority: low ux
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
cole (Cole Keller) jared (Jared Vititoe) nathan (Nathan Vititoe)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: LotusGuild/cinny#336