Deafen button's aria-label is inverted relative to its tooltip #33

Closed
opened 2026-09-12 01:51:04 -04:00 by jared · 0 comments
Owner

Severity: medium · Type: a11y · Confidence: high

Location: src/app/features/call/Controls.tsx:56-84 (tooltip line 62, aria-label line 77)

Problem

in the in-call SoundButton, enabled means "sound is on". The tooltip correctly reads enabled ? 'Deafen' : 'Undeafen' (the action), but the aria-label two lines later is enabled ? 'Undeafen' : 'Deafen' — exactly backwards. A screen-reader user is told the button will "Undeafen" while sound is on and "Deafen" while already deafened. The equivalent button in features/call-status/CallControl.tsx:159 has it the right way round (and also sets aria-pressed, which the in-call one omits), so the two bars disagree.

How to trigger

navigate the in-call control bar with a screen reader.

Suggested fix

swap the ternary to enabled ? 'Deafen' : 'Undeafen' and add aria-pressed={enabled} to match the call-status button.


Filed from the September 2026 client audit (branch lotus @ 4bea4895).

**Severity:** medium · **Type:** a11y · **Confidence:** high **Location:** `src/app/features/call/Controls.tsx:56-84` (tooltip line 62, `aria-label` line 77) ### Problem in the in-call `SoundButton`, `enabled` means "sound is on". The tooltip correctly reads `enabled ? 'Deafen' : 'Undeafen'` (the action), but the `aria-label` two lines later is `enabled ? 'Undeafen' : 'Deafen'` — exactly backwards. A screen-reader user is told the button will "Undeafen" while sound is on and "Deafen" while already deafened. The equivalent button in `features/call-status/CallControl.tsx:159` has it the right way round (and also sets `aria-pressed`, which the in-call one omits), so the two bars disagree. ### How to trigger navigate the in-call control bar with a screen reader. ### Suggested fix swap the ternary to `enabled ? 'Deafen' : 'Undeafen'` and add `aria-pressed={enabled}` to match the call-status button. --- _Filed from the September 2026 client audit (branch `lotus` @ 4bea4895)._
jared added this to the Audit 2026-09 · Medium & Low milestone 2026-09-12 01:51:04 -04:00
jared added the priority: mediuma11yarea: calls labels 2026-09-12 01:51:04 -04:00
jared self-assigned this 2026-09-12 01:51:04 -04:00
jared closed this issue 2026-09-12 02:14:51 -04:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
2026-11-14
Dependencies

No dependencies set.

Reference: LotusGuild/cinny#33