LotusGuild/cinny
3
0
Fork 0
Code Issues 27 Pull Requests 5 Actions Packages Projects Releases Wiki Activity

Terms-consent prompt: every close (including "I've accepted — retry") snoozes it for 10 s, so a retry that fails again is silent #311

New Issue
Closed
opened 2026-10-05 00:17:39 -04:00 by jared · 0 comments
jared commented 2026-10-05 00:17:39 -04:00
Owner
Copy Link
Copy Source

Checked with a routed 403 M_CONSENT_NOT_GIVEN (c96c47dd, src/app/components/ConsentRequiredPrompt.tsx):

  • the dialog explains the failure;
  • "Review and accept" opens the consent_uri in a new tab;
  • a javascript: consent_uri gets no button;
  • "I've accepted — retry sending" re-sends after real acceptance (server copies: 1).

Gap: the FocusTrap's onDeactivate: later also runs when the dialog closes because of Retry, because unmounting deactivates the trap. Every close therefore sets the 10 s snooze. If the user presses "I've accepted — retry" before finishing in the other tab, which is easy when the terms page needs a login, the retry gets another M_CONSENT_NOT_GIVEN. No dialog appears; the message just goes back to "Failed to send". Measured: dialog shown on the first failure; after Retry while still not accepted, no dialog; a send more than 10 s later shows it again.

Fix: only snooze from "Later", Escape or an outside click. Pass onDeactivate a flag that retry sets, or call later explicitly from those paths. Or always reopen when a retry from the dialog fails again.

Found in the October 2026 client audit (Playwright against a local Synapse + LiveKit stack, plus code reading). Code refs are at cinny 30e2dbcd, cinny-desktop 8f67ec7, element-call 3b0050e8.

Checked with a routed `403 M_CONSENT_NOT_GIVEN` (c96c47dd, `src/app/components/ConsentRequiredPrompt.tsx`): - the dialog explains the failure; - "Review and accept" opens the `consent_uri` in a new tab; - a `javascript:` `consent_uri` gets no button; - "I've accepted — retry sending" re-sends after real acceptance (server copies: 1). **Gap:** the FocusTrap's `onDeactivate: later` also runs when the dialog closes because of **Retry**, because unmounting deactivates the trap. Every close therefore sets the 10 s snooze. If the user presses "I've accepted — retry" before finishing in the other tab, which is easy when the terms page needs a login, the retry gets another `M_CONSENT_NOT_GIVEN`. **No dialog appears**; the message just goes back to "Failed to send". Measured: dialog shown on the first failure; after Retry while still not accepted, no dialog; a send more than 10 s later shows it again. **Fix:** only snooze from "Later", Escape or an outside click. Pass `onDeactivate` a flag that `retry` sets, or call `later` explicitly from those paths. Or always reopen when a retry from the dialog fails again. --- _Found in the October 2026 client audit (Playwright against a local Synapse + LiveKit stack, plus code reading). Code refs are at cinny `30e2dbcd`, cinny-desktop `8f67ec7`, element-call `3b0050e8`._
jared added the priority: lowuxarea: messaging labels 2026-10-05 00:17:39 -04:00
jared closed this issue 2026-10-18 06:51:25 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
a11y
Accessibility: keyboard, screen reader, contrast, motion
 area: appearance
Client area: appearance
 area: auth-session
Client area: auth-session
 area: build-ci
Client area: build-ci
 area: calls
Client area: calls
 area: desktop
Client area: desktop
 area: media
Client area: media
 area: messaging
Client area: messaging
 area: mobile
Client area: mobile
 area: moderation
Client area: moderation
 area: navigation
Client area: navigation
 area: notifications
Client area: notifications
 area: settings
Client area: settings
 area: threads
Client area: threads
 bug
Something is not working
 dependencies
Third-party package versions and advisories
 docs
README / LOTUS_* docs wrong or missing
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 needs-human-review
performance
Re-render storms, leaks, heavy work on hot paths
 planning
priority: critical
Data loss, security hole, or crash on a main path
 priority: high
Broken feature or serious usability problem
 priority: low
Minor issue or polish
 priority: medium
Wrong behaviour in an edge case or notable degradation
 qa
Manual QA: shipped, needs a human in a real environment
 question
More information is needed
 research
security
XSS, unsafe URLs, data leaks, auth/session
 tech-debt
Code health, dead code, fragile patterns
 ux
Usability or visual inconsistency
 wontfix
This won't be fixed
No labels area: messaging priority: low ux
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
cole (Cole Keller) jared (Jared Vititoe) nathan (Nathan Vititoe)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: LotusGuild/cinny#311