LotusGuild/cinny
3
0
Fork 0
Code Issues 27 Pull Requests 5 Actions Packages Projects Releases Wiki Activity

"Rejoin voice?" reads "in the call in Bob Builder" for DMs, and is offered for DM calls that already ended #302

New Issue
Closed
opened 2026-10-04 21:19:33 -04:00 by jared · 1 comment
jared commented 2026-10-04 21:19:33 -04:00
Owner
Copy Link
Copy Source

After a reload during a DM call, the rejoin toast (#118, useCallRejoin) says:

Rejoin voice? You were in the call in Bob Builder before the restart. Tap to rejoin.

  • Wording. For a DM, "in Bob Builder" is the room name (the other person's name). It should read "You were in a call with Bob Builder".
  • Ended calls. The toast also appeared after the other person had already hung up (their call membership hadn't expired yet). decideRejoin counts any membership that isn't ours as "the call is still going". A stale leave can therefore produce a rejoin into an empty DM call, which then rings the other person again (StartCallDM → ring).

Fix

  • Use DM-aware copy (directs.has(roomId)).
  • For DMs, require the other member's membership to be fresh (e.g. updated within the last minute), or skip auto/ask entirely for DMs and just show "Call ended".

Found in the October 2026 client audit (Playwright against a local Synapse + LiveKit stack, plus code reading). Code refs are at cinny 30e2dbcd, cinny-desktop 8f67ec7, element-call 3b0050e8.

After a reload during a **DM** call, the rejoin toast (#118, `useCallRejoin`) says: > **Rejoin voice?** You were in the call in **Bob Builder** before the restart. Tap to rejoin. - **Wording.** For a DM, "in Bob Builder" is the room name (the other person's name). It should read "You were in a call **with** Bob Builder". - **Ended calls.** The toast also appeared after the other person had already hung up (their call membership hadn't expired yet). `decideRejoin` counts any membership that isn't ours as "the call is still going". A stale leave can therefore produce a rejoin into an empty DM call, which then rings the other person again (`StartCallDM` → `ring`). **Fix** - Use DM-aware copy (`directs.has(roomId)`). - For DMs, require the other member's membership to be fresh (e.g. updated within the last minute), or skip auto/ask entirely for DMs and just show "Call ended". --- _Found in the October 2026 client audit (Playwright against a local Synapse + LiveKit stack, plus code reading). Code refs are at cinny `30e2dbcd`, cinny-desktop `8f67ec7`, element-call `3b0050e8`._
jared added the priority: lowuxarea: calls labels 2026-10-04 21:19:33 -04:00
jared commented 2026-10-05 01:16:00 -04:00
Author
Owner
Copy Link
Copy Source

Probable root cause of the "Ended calls" half, found later: #312. After a reload, mx.matrixRTC.getRoomSession(room).memberships stays stale: it still lists the other person even though room state says they left. A manual refreshRoom(room) clears it. decideRejoin reads that stale session. Fixing the refresh as described in #312 should fix this too; the DM wording part still stands.

Probable root cause of the "Ended calls" half, found later: #312. After a reload, `mx.matrixRTC.getRoomSession(room).memberships` stays stale: it still lists the other person even though room state says they left. A manual `refreshRoom(room)` clears it. `decideRejoin` reads that stale session. Fixing the refresh as described in #312 should fix this too; the DM wording part still stands.
jared closed this issue 2026-10-18 01:16:24 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
a11y
Accessibility: keyboard, screen reader, contrast, motion
 area: appearance
Client area: appearance
 area: auth-session
Client area: auth-session
 area: build-ci
Client area: build-ci
 area: calls
Client area: calls
 area: desktop
Client area: desktop
 area: media
Client area: media
 area: messaging
Client area: messaging
 area: mobile
Client area: mobile
 area: moderation
Client area: moderation
 area: navigation
Client area: navigation
 area: notifications
Client area: notifications
 area: settings
Client area: settings
 area: threads
Client area: threads
 bug
Something is not working
 dependencies
Third-party package versions and advisories
 docs
README / LOTUS_* docs wrong or missing
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 needs-human-review
performance
Re-render storms, leaks, heavy work on hot paths
 planning
priority: critical
Data loss, security hole, or crash on a main path
 priority: high
Broken feature or serious usability problem
 priority: low
Minor issue or polish
 priority: medium
Wrong behaviour in an edge case or notable degradation
 qa
Manual QA: shipped, needs a human in a real environment
 question
More information is needed
 research
security
XSS, unsafe URLs, data leaks, auth/session
 tech-debt
Code health, dead code, fragile patterns
 ux
Usability or visual inconsistency
 wontfix
This won't be fixed
No labels area: calls priority: low ux
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
cole (Cole Keller) jared (Jared Vititoe) nathan (Nathan Vititoe)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: LotusGuild/cinny#302