LotusGuild/cinny
3
0
Fork 0
Code Issues 27 Pull Requests 5 Actions Packages Projects Releases Wiki Activity

Message search lists an edited message once per version #288

New Issue
Closed
opened 2026-10-04 19:50:21 -04:00 by jared · 0 comments
jared commented 2026-10-04 19:50:21 -04:00
Owner
Copy Link
Copy Source

Searching meeting returned three rows for one message (screenshot): "Monday 10am room A" (original), "Tuesday 10am room A" (edit 1) and "Tuesday 11am room B" (edit 2). Server-side search returns the m.replace events too, and the results list renders each as its own message.

Fix: drop results whose m.relates_to.rel_type is m.replace (or fold them into their target and show the latest content once). This probably comes from upstream Cinny's search; it's still visible in Lotus.

Screenshot

F33-search-edit-dupes.png

Found in the October 2026 client audit (Playwright against a local Synapse + LiveKit stack, plus code reading). Code refs are at cinny 30e2dbcd, cinny-desktop 8f67ec7, element-call 3b0050e8.

Searching `meeting` returned **three rows for one message** (screenshot): "Monday 10am room A" (original), "Tuesday 10am room A" (edit 1) and "Tuesday 11am room B" (edit 2). Server-side search returns the `m.replace` events too, and the results list renders each as its own message. **Fix:** drop results whose `m.relates_to.rel_type` is `m.replace` (or fold them into their target and show the latest content once). This probably comes from upstream Cinny's search; it's still visible in Lotus. **Screenshot** ![F33-search-edit-dupes.png](https://code.lotusguild.org/attachments/336dccf9-0212-476e-a3e3-a45ba295d4f2) --- _Found in the October 2026 client audit (Playwright against a local Synapse + LiveKit stack, plus code reading). Code refs are at cinny `30e2dbcd`, cinny-desktop `8f67ec7`, element-call `3b0050e8`._
F33-search-edit-dupes.png
158 KiB
jared added the priority: lowuxarea: messaging labels 2026-10-04 19:50:21 -04:00
jared closed this issue 2026-10-18 00:59:47 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
a11y
Accessibility: keyboard, screen reader, contrast, motion
 area: appearance
Client area: appearance
 area: auth-session
Client area: auth-session
 area: build-ci
Client area: build-ci
 area: calls
Client area: calls
 area: desktop
Client area: desktop
 area: media
Client area: media
 area: messaging
Client area: messaging
 area: mobile
Client area: mobile
 area: moderation
Client area: moderation
 area: navigation
Client area: navigation
 area: notifications
Client area: notifications
 area: settings
Client area: settings
 area: threads
Client area: threads
 bug
Something is not working
 dependencies
Third-party package versions and advisories
 docs
README / LOTUS_* docs wrong or missing
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 needs-human-review
performance
Re-render storms, leaks, heavy work on hot paths
 planning
priority: critical
Data loss, security hole, or crash on a main path
 priority: high
Broken feature or serious usability problem
 priority: low
Minor issue or polish
 priority: medium
Wrong behaviour in an edge case or notable degradation
 qa
Manual QA: shipped, needs a human in a real environment
 question
More information is needed
 research
security
XSS, unsafe URLs, data leaks, auth/session
 tech-debt
Code health, dead code, fragile patterns
 ux
Usability or visual inconsistency
 wontfix
This won't be fixed
No labels area: messaging priority: low ux
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
cole (Cole Keller) jared (Jared Vititoe) nathan (Nathan Vititoe)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: LotusGuild/cinny#288