LotusGuild/cinny
3
0
Fork 0
Code Issues 45 Pull Requests 4 Actions 1 Packages Projects Releases Wiki Activity

Desktop: "Copy Lotus Link" copies a localhost address; public Lotus links not recognised in-app #248

New Issue
Closed
opened 2026-09-28 19:30:22 -04:00 by jared · 1 comment
jared commented 2026-09-28 19:30:22 -04:00
Owner
Copy Link
Copy Source

Desktop app: "Copy Lotus Link" copies a local address

Lotus permalinks (#130) are built from getOriginBaseUrl(), i.e. window.location.origin. On the web that's https://chat.lotusguild.org. In the desktop app it's the app's local server (tauri-plugin-localhost), and the desktop config uses the hash router. So a link copied from the desktop app looks like http://localhost:…/#/home/!room… and works for nobody else.

Affected:

  • Copying: "Copy Lotus Link" on messages (Message.tsx), and the space link in the space menu (Space.tsx) and space tabs (SpaceTabs.tsx).
  • Recognising: the link recogniser (setLotusPermalinkBase in ClientNonUIFeatures.tsx → react-custom-html-parser) only knows the local address. So clicking a real https://chat.lotusguild.org/home/… link inside the desktop app opens the browser instead of the room in the app.

Fix:

  • In the desktop app, use config webAppUrl (added in cinny-desktop #23, https only) as the base for shared links, in the web app's path-routing format.
  • Recognise both the public base and the local one.
  • The web app is unchanged. Without webAppUrl, behaviour stays as today.
## Desktop app: "Copy Lotus Link" copies a local address Lotus permalinks (#130) are built from `getOriginBaseUrl()`, i.e. `window.location.origin`. On the web that's `https://chat.lotusguild.org`. In the **desktop app** it's the app's local server (tauri-plugin-localhost), and the desktop config uses the hash router. So a link copied from the desktop app looks like `http://localhost:…/#/home/!room…` and works for nobody else. **Affected:** - **Copying:** "Copy Lotus Link" on messages (`Message.tsx`), and the space link in the space menu (`Space.tsx`) and space tabs (`SpaceTabs.tsx`). - **Recognising:** the link recogniser (`setLotusPermalinkBase` in `ClientNonUIFeatures.tsx` → `react-custom-html-parser`) only knows the local address. So clicking a real `https://chat.lotusguild.org/home/…` link inside the desktop app opens the browser instead of the room in the app. **Fix:** - In the desktop app, use config `webAppUrl` (added in cinny-desktop #23, https only) as the base for shared links, in the web app's path-routing format. - Recognise both the public base and the local one. - The web app is unchanged. Without `webAppUrl`, behaviour stays as today.
jared added the bugpriority: mediumarea: desktop labels 2026-09-28 19:30:22 -04:00
jared commented 2026-09-28 20:36:22 -04:00
Author
Owner
Copy Link
Copy Source

Fixed in #249 (merged c0c93213, live on chat.lotusguild.org since 23:55 UTC).

  • Copy Lotus Link (desktop): message and space links use webAppUrl, e.g. https://chat.lotusguild.org/home/!room…/$event…?viaServers=…, instead of the local http://localhost:44548/#/… address.
  • Public links in messages (desktop): they're recognised, render as room pills and open in-app.
  • Web app: unchanged.

The desktop app picks this up in the next nightly build.

Fixed in #249 (merged `c0c93213`, live on chat.lotusguild.org since 23:55 UTC). - **Copy Lotus Link (desktop):** message and space links use `webAppUrl`, e.g. `https://chat.lotusguild.org/home/!room…/$event…?viaServers=…`, instead of the local `http://localhost:44548/#/…` address. - **Public links in messages (desktop):** they're recognised, render as room pills and open in-app. - **Web app:** unchanged. The desktop app picks this up in the next nightly build.
jared closed this issue 2026-09-28 20:36:22 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
a11y
Accessibility: keyboard, screen reader, contrast, motion
 area: appearance
Client area: appearance
 area: auth-session
Client area: auth-session
 area: build-ci
Client area: build-ci
 area: calls
Client area: calls
 area: desktop
Client area: desktop
 area: media
Client area: media
 area: messaging
Client area: messaging
 area: mobile
Client area: mobile
 area: moderation
Client area: moderation
 area: navigation
Client area: navigation
 area: notifications
Client area: notifications
 area: settings
Client area: settings
 area: threads
Client area: threads
 bug
Something is not working
 dependencies
Third-party package versions and advisories
 docs
README / LOTUS_* docs wrong or missing
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 needs-human-review
performance
Re-render storms, leaks, heavy work on hot paths
 planning
priority: critical
Data loss, security hole, or crash on a main path
 priority: high
Broken feature or serious usability problem
 priority: low
Minor issue or polish
 priority: medium
Wrong behaviour in an edge case or notable degradation
 qa
Manual QA: shipped, needs a human in a real environment
 question
More information is needed
 research
security
XSS, unsafe URLs, data leaks, auth/session
 tech-debt
Code health, dead code, fragile patterns
 ux
Usability or visual inconsistency
 wontfix
This won't be fixed
No labels area: desktop bug priority: medium
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
cole (Cole Keller) jared (Jared Vititoe) nathan (Nathan Vititoe)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: LotusGuild/cinny#248