/kick and /ban failures are silent (rateLimitedActions swallows non-429 errors) #216

New Issue

2026-09-18T19:27:25-04:00

jared commented

2026-09-18 19:27:25 -04:00

Verified under #187 DP1: /join #does-not-exist:localhost shows "Command failed: The /join command failed. Please try again." but /kick @nobody:localhost in a room where you cannot kick clears the composer and shows nothing. The code already documents why (useCommands.ts:295-298): rateLimitedActions' to() helper swallows every non-429 error, so the exe() catch in RoomInput never fires. Same for /ban.

Fix: have rateLimitedActions collect per-item failures and rethrow (or return) them after the loop so the command layer can toast "Could not kick @x: you don't have permission" — the error text is in the MatrixError already.

Verified under #187 DP1: `/join #does-not-exist:localhost` shows "Command failed: The /join command failed. Please try again." but `/kick @nobody:localhost` in a room where you cannot kick clears the composer and shows **nothing**. The code already documents why (`useCommands.ts:295-298`): `rateLimitedActions`' `to()` helper swallows every non-429 error, so the `exe()` catch in `RoomInput` never fires. Same for `/ban`. Fix: have `rateLimitedActions` collect per-item failures and rethrow (or return) them after the loop so the command layer can toast "Could not kick @x: you don't have permission" — the error text is in the MatrixError already.

jared added the bug priority: low ux area: messaging labels 2026-09-18 19:27:25 -04:00

jared referenced this issue

2026-09-18 19:27:26 -04:00

[QA] §R Discovery-pass fixes DP1–DP18: correctness, a11y/UX, TDS colours, refactor regression pass #187

jared commented

2026-09-19 12:40:57 -04:00

Fixed in 60076a48. rateLimitedActions now returns { failures } (non-429 errors, plus a 429 that exhausted its retries) instead of swallowing them; existing callers ignore the return. /kick and /ban turn the list into a CommandError whose message names who and why, using the server's own sentence (MatrixError.data.error) — never the URL-bearing toString() — and the RoomInput toast shows it verbatim.

Verified headless as a non-moderator in Busy Room:

/kick @alice:localhost → toast "Could not kick @alice:localhost: You cannot kick user @alice:localhost."
/ban @nobody:localhost @alice:localhost → "Could not ban @nobody:localhost, @alice:localhost: You don't have permission to ban"

(Side note for testers: as upstream, a command only counts when picked from the autocomplete — typing /kick … and pressing Enter without the chip sends it as plain text.)

Fixed in `60076a48`. `rateLimitedActions` now returns `{ failures }` (non-429 errors, plus a 429 that exhausted its retries) instead of swallowing them; existing callers ignore the return. `/kick` and `/ban` turn the list into a `CommandError` whose message names who and why, using the server's own sentence (`MatrixError.data.error`) — never the URL-bearing `toString()` — and the RoomInput toast shows it verbatim. Verified headless as a non-moderator in Busy Room: - `/kick @alice:localhost` → toast **"Could not kick @alice:localhost: You cannot kick user @alice:localhost."** - `/ban @nobody:localhost @alice:localhost` → **"Could not ban @nobody:localhost, @alice:localhost: You don't have permission to ban"** (Side note for testers: as upstream, a command only counts when picked from the autocomplete — typing `/kick …` and pressing Enter without the chip sends it as plain text.)

jared closed this issue

2026-09-19 12:40:57 -04:00

jared referenced this issue from a commit

2026-09-19 12:40:59 -04:00

fix(commands): /kick and /ban failures are no longer silent (#216)

jared referenced this issue from a commit

2026-09-19 22:38:43 -04:00

ci(e2e): tier-3 regression suite against a Synapse the job starts itself (#220)

jared referenced this issue

2026-09-19 22:46:15 -04:00

CI: e2e job that starts its own Synapse and runs the UI regression suite (no prod secrets) #220

Sign in to join this conversation.