favoriteRooms/lowPriorityRooms/otherRooms are derived in a useMemo keyed only on [mx, rooms], where rooms comes from useHomeRooms() (backed by allRoomsAtom/roomToParentsAtom/mDirectAtom). None of those atoms are updated when a room's m.tag account-data changes — there is no listener anywhere in the codebase for RoomEvent/tag changes feeding into these atoms (grep for RoomEvent.Tags in src/app returns nothing). RoomNavItemMenu.handleToggleFavorite/handleToggleLowPriority call mx.setRoomTag/mx.deleteRoomTag directly, which mutates room.tags on the SDK's Room object but does not itself trigger any atom update. As a result, right-clicking a room and choosing "Add to Favorites" (or Low Priority) does not move the room into the Favorites/Low-Priority section, and the star icon in RoomNavItem does not appear, until some unrelated event causes rooms, roomToUnreadSet, or homeRoomSort to change (e.g. a new message arrives in some other room, changing the unread set) and forces the whole tree to re-render and pick up the mutated (but by-then possibly stale local-echo vs. server-confirmed) room.tags.
Lead review note: this is inherited upstream Cinny code; confirmed by reading that nothing subscribes to tag changes, but please confirm the symptom in the live app before fixing.
How to trigger
Right-click any room in the sidebar → "Add to Favorites". Observe the room stays in its original section and has no star icon until some other UI event forces a re-render (can take minutes on a quiet account, or never during the session).
Suggested fix
Subscribe to the SDK's room tags update (there's no dedicated RoomEvent for tags in js-sdk; account-data Room.accountData/sync events fire when m.tag room account data changes) and bump a counter/atom on tag changes so Home.tsx's categorisation memo re-runs — mirroring the pattern already used for roomToUnreadAtom.
Filed from the September 2026 client audit (branch lotus @ 4bea4895).
**Severity:** high · **Type:** bug · **Confidence:** medium
**Location:** `src/app/pages/client/home/Home.tsx:257-354`, `src/app/features/room-nav/RoomNavItem.tsx:353-377`
### Problem
`favoriteRooms`/`lowPriorityRooms`/`otherRooms` are derived in a `useMemo` keyed only on `[mx, rooms]`, where `rooms` comes from `useHomeRooms()` (backed by `allRoomsAtom`/`roomToParentsAtom`/`mDirectAtom`). None of those atoms are updated when a room's `m.tag` account-data changes — there is no listener anywhere in the codebase for `RoomEvent`/tag changes feeding into these atoms (`grep` for `RoomEvent.Tags` in `src/app` returns nothing). `RoomNavItemMenu.handleToggleFavorite`/`handleToggleLowPriority` call `mx.setRoomTag`/`mx.deleteRoomTag` directly, which mutates `room.tags` on the SDK's `Room` object but does not itself trigger any atom update. As a result, right-clicking a room and choosing "Add to Favorites" (or Low Priority) does not move the room into the Favorites/Low-Priority section, and the star icon in `RoomNavItem` does not appear, until some unrelated event causes `rooms`, `roomToUnreadSet`, or `homeRoomSort` to change (e.g. a new message arrives in some other room, changing the unread set) and forces the whole tree to re-render and pick up the mutated (but by-then possibly stale local-echo vs. server-confirmed) `room.tags`.
**Lead review note:** this is inherited upstream Cinny code; confirmed by reading that nothing subscribes to tag changes, but please confirm the symptom in the live app before fixing.
### How to trigger
Right-click any room in the sidebar → "Add to Favorites". Observe the room stays in its original section and has no star icon until some other UI event forces a re-render (can take minutes on a quiet account, or never during the session).
### Suggested fix
Subscribe to the SDK's room tags update (there's no dedicated `RoomEvent` for tags in js-sdk; account-data `Room.accountData`/`sync` events fire when `m.tag` room account data changes) and bump a counter/atom on tag changes so `Home.tsx`'s categorisation memo re-runs — mirroring the pattern already used for `roomToUnreadAtom`.
---
---
_Filed from the September 2026 client audit (branch `lotus` @ 4bea4895)._
jared
added this to the Audit 2026-09 · High milestone 2026-09-12 01:50:54 -04:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Severity: high · Type: bug · Confidence: medium
Location:
src/app/pages/client/home/Home.tsx:257-354,src/app/features/room-nav/RoomNavItem.tsx:353-377Problem
favoriteRooms/lowPriorityRooms/otherRoomsare derived in auseMemokeyed only on[mx, rooms], whereroomscomes fromuseHomeRooms()(backed byallRoomsAtom/roomToParentsAtom/mDirectAtom). None of those atoms are updated when a room'sm.tagaccount-data changes — there is no listener anywhere in the codebase forRoomEvent/tag changes feeding into these atoms (grepforRoomEvent.Tagsinsrc/appreturns nothing).RoomNavItemMenu.handleToggleFavorite/handleToggleLowPrioritycallmx.setRoomTag/mx.deleteRoomTagdirectly, which mutatesroom.tagson the SDK'sRoomobject but does not itself trigger any atom update. As a result, right-clicking a room and choosing "Add to Favorites" (or Low Priority) does not move the room into the Favorites/Low-Priority section, and the star icon inRoomNavItemdoes not appear, until some unrelated event causesrooms,roomToUnreadSet, orhomeRoomSortto change (e.g. a new message arrives in some other room, changing the unread set) and forces the whole tree to re-render and pick up the mutated (but by-then possibly stale local-echo vs. server-confirmed)room.tags.Lead review note: this is inherited upstream Cinny code; confirmed by reading that nothing subscribes to tag changes, but please confirm the symptom in the live app before fixing.
How to trigger
Right-click any room in the sidebar → "Add to Favorites". Observe the room stays in its original section and has no star icon until some other UI event forces a re-render (can take minutes on a quiet account, or never during the session).
Suggested fix
Subscribe to the SDK's room tags update (there's no dedicated
RoomEventfor tags in js-sdk; account-dataRoom.accountData/syncevents fire whenm.tagroom account data changes) and bump a counter/atom on tag changes soHome.tsx's categorisation memo re-runs — mirroring the pattern already used forroomToUnreadAtom.Filed from the September 2026 client audit (branch
lotus@4bea4895).