RuleModeSwitcher (used by every row in the "Advanced Push Rules" editor) calls useNotificationModeActions() with no options, so getModeActions(mode) always builds actions from scratch as [Notify] (+ a sound tweak for "Notify Loud") and never re-applies highlight. Writing mx.setPushRuleActions(...) with that action list replaces the rule's entire actions array. Default rules such as .m.rule.is_user_mention, .m.rule.contains_display_name, .m.rule.is_room_mention and .m.rule.at_room_notification normally ship with a highlight: true tweak; toggling their mode from this generic editor (e.g. switching "Notify Loud" → "Notify Silent" to mute the sound) silently drops the highlight tweak from the account-data push rule, which syncs to every client on the account. The parallel purpose-built editors for the same rules (SpecialMessages.tsx, KeywordMessages.tsx) correctly pass NotificationModeOptions{ highlight: true } — confirming this is an oversight specific to the generic Advanced editor, not an intentional simplification.
How to trigger
Settings → Notifications → Advanced Push Rules → expand "Override Rules" → change the mode of .m.rule.is_user_mention (or .m.rule.contains_display_name/.m.rule.is_room_mention) via the dropdown. The rule keeps notifying but a real @mention or display-name hit no longer highlights (red badge / bold) in the room list or timeline, on every device, until the user manually re-sets it from the Special Messages page.
Suggested fix
Have RuleModeSwitcher/getModeActions preserve any existing set_tweak: highlight (and non-default sound values) from pushRule.actions when rebuilding the action list, the same way SpecialMessages.tsx/KeywordMessages.tsx pass { highlight: true } — or read the existing tweaks off pushRule.actions instead of hard-coding options.
Filed from the September 2026 client audit (branch lotus @ 4bea4895).
**Severity:** high · **Type:** bug · **Confidence:** high
**Location:** `src/app/features/settings/notifications/PushRuleEditor.tsx:132-145`, `src/app/hooks/useNotificationMode.ts:26-47`
### Problem
`RuleModeSwitcher` (used by every row in the "Advanced Push Rules" editor) calls `useNotificationModeActions()` with **no options**, so `getModeActions(mode)` always builds actions from scratch as `[Notify]` (+ a `sound` tweak for "Notify Loud") and never re-applies `highlight`. Writing `mx.setPushRuleActions(...)` with that action list *replaces* the rule's entire actions array. Default rules such as `.m.rule.is_user_mention`, `.m.rule.contains_display_name`, `.m.rule.is_room_mention` and `.m.rule.at_room_notification` normally ship with a `highlight: true` tweak; toggling their mode from this generic editor (e.g. switching "Notify Loud" → "Notify Silent" to mute the sound) silently drops the highlight tweak from the account-data push rule, which syncs to every client on the account. The parallel purpose-built editors for the same rules (`SpecialMessages.tsx`, `KeywordMessages.tsx`) correctly pass `NotificationModeOptions{ highlight: true }` — confirming this is an oversight specific to the generic Advanced editor, not an intentional simplification.
### How to trigger
Settings → Notifications → Advanced Push Rules → expand "Override Rules" → change the mode of `.m.rule.is_user_mention` (or `.m.rule.contains_display_name`/`.m.rule.is_room_mention`) via the dropdown. The rule keeps notifying but a real @mention or display-name hit no longer highlights (red badge / bold) in the room list or timeline, on every device, until the user manually re-sets it from the Special Messages page.
### Suggested fix
Have `RuleModeSwitcher`/`getModeActions` preserve any existing `set_tweak: highlight` (and non-default sound values) from `pushRule.actions` when rebuilding the action list, the same way `SpecialMessages.tsx`/`KeywordMessages.tsx` pass `{ highlight: true }` — or read the existing tweaks off `pushRule.actions` instead of hard-coding options.
---
_Filed from the September 2026 client audit (branch `lotus` @ 4bea4895)._
jared
added this to the Audit 2026-09 · High milestone 2026-09-12 01:50:53 -04:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Severity: high · Type: bug · Confidence: high
Location:
src/app/features/settings/notifications/PushRuleEditor.tsx:132-145,src/app/hooks/useNotificationMode.ts:26-47Problem
RuleModeSwitcher(used by every row in the "Advanced Push Rules" editor) callsuseNotificationModeActions()with no options, sogetModeActions(mode)always builds actions from scratch as[Notify](+ asoundtweak for "Notify Loud") and never re-applieshighlight. Writingmx.setPushRuleActions(...)with that action list replaces the rule's entire actions array. Default rules such as.m.rule.is_user_mention,.m.rule.contains_display_name,.m.rule.is_room_mentionand.m.rule.at_room_notificationnormally ship with ahighlight: truetweak; toggling their mode from this generic editor (e.g. switching "Notify Loud" → "Notify Silent" to mute the sound) silently drops the highlight tweak from the account-data push rule, which syncs to every client on the account. The parallel purpose-built editors for the same rules (SpecialMessages.tsx,KeywordMessages.tsx) correctly passNotificationModeOptions{ highlight: true }— confirming this is an oversight specific to the generic Advanced editor, not an intentional simplification.How to trigger
Settings → Notifications → Advanced Push Rules → expand "Override Rules" → change the mode of
.m.rule.is_user_mention(or.m.rule.contains_display_name/.m.rule.is_room_mention) via the dropdown. The rule keeps notifying but a real @mention or display-name hit no longer highlights (red badge / bold) in the room list or timeline, on every device, until the user manually re-sets it from the Special Messages page.Suggested fix
Have
RuleModeSwitcher/getModeActionspreserve any existingset_tweak: highlight(and non-default sound values) frompushRule.actionswhen rebuilding the action list, the same waySpecialMessages.tsx/KeywordMessages.tsxpass{ highlight: true }— or read the existing tweaks offpushRule.actionsinstead of hard-coding options.Filed from the September 2026 client audit (branch
lotus@4bea4895).