The viewer already steps ← → between the room's images. Audit it end-to-end on desktop and phone: keyboard (arrows, Esc, +/−, 0), swipe/pinch on touch, zoom persistence between items, video controls vs. image controls, captions display, download/copy/open-in-new-tab, "jump to message", loading states + blurhash, very tall/wide images, GIFs vs. videos, E2EE media, focus trap + screen reader labels, and what happens when a new image arrives while open. Deliver findings as a checklist here, then fix in one reviewed batch.
The viewer already steps ← → between the room's images. Audit it end-to-end on desktop and phone: keyboard (arrows, Esc, +/−, 0), swipe/pinch on touch, zoom persistence between items, video controls vs. image controls, captions display, download/copy/open-in-new-tab, "jump to message", loading states + blurhash, very tall/wide images, GIFs vs. videos, E2EE media, focus trap + screen reader labels, and what happens when a new image arrives while open. Deliver findings as a checklist here, then fix in one reviewed batch.
Image viewer audit — exercised on the local dev homeserver (Playwright, desktop + Pixel 7)
There are two viewers and they behave differently:
timeline ImageViewer
gallery lightbox
backdrop
light grey card
dark full-screen
header
file name only
file name, sender · date, 1 / N
prev / next
none
←/→ across the room's media
zoom
buttons, wheel; no keys (fixed)
buttons, wheel, + - 0, double-click
keyboard on open
focus on the <img> (fixed)
focus stayed on the tile behind — all keys dead until a click (fixed)
a11y
no role / label (fixed)
role=dialog aria-modal "Media viewer"
download
✓
✓
jump to message
n/a
✓
touch
buttons only, no pinch
buttons only, no pinch
Fixed (53823f54): lightbox now focuses itself on open so ←/→/Esc/+/- work immediately; the timeline viewer gained + / = / - / 0, double-click 1×↔2×, role=dialog aria-modal labelled with the file name, and focuses on open. Escape closes both.
Filed:#219 — unify: a timeline image should open the gallery lightbox at that item (dark backdrop, sender/time, prev/next, consistent keys), and add pinch-zoom; the small viewer then only remains for avatars.
Cosmetic seen along the way: the seasonal floating button sits on top of both viewers (#215).
## Image viewer audit — exercised on the local dev homeserver (Playwright, desktop + Pixel 7)
There are **two** viewers and they behave differently:
| | timeline `ImageViewer` | gallery lightbox |
|---|---|---|
| backdrop | light grey card | dark full-screen |
| header | file name only | file name, **sender · date**, 1 / N |
| prev / next | none | ←/→ across the room's media |
| zoom | buttons, wheel; **no keys** (fixed) | buttons, wheel, + - 0, double-click |
| keyboard on open | focus on the `<img>` (fixed) | **focus stayed on the tile behind — all keys dead until a click** (fixed) |
| a11y | no role / label (fixed) | `role=dialog aria-modal` "Media viewer" |
| download | ✓ | ✓ |
| jump to message | n/a | ✓ |
| touch | buttons only, no pinch | buttons only, no pinch |
**Fixed (`53823f54`):** lightbox now focuses itself on open so ←/→/Esc/+/- work immediately; the timeline viewer gained + / = / - / 0, double-click 1×↔2×, `role=dialog aria-modal` labelled with the file name, and focuses on open. Escape closes both.
**Filed:** #219 — unify: a timeline image should open the gallery lightbox at that item (dark backdrop, sender/time, prev/next, consistent keys), and add pinch-zoom; the small viewer then only remains for avatars.
Cosmetic seen along the way: the seasonal floating button sits on top of both viewers (#215).
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
The viewer already steps ← → between the room's images. Audit it end-to-end on desktop and phone: keyboard (arrows, Esc, +/−, 0), swipe/pinch on touch, zoom persistence between items, video controls vs. image controls, captions display, download/copy/open-in-new-tab, "jump to message", loading states + blurhash, very tall/wide images, GIFs vs. videos, E2EE media, focus trap + screen reader labels, and what happens when a new image arrives while open. Deliver findings as a checklist here, then fix in one reviewed batch.
Image viewer audit — exercised on the local dev homeserver (Playwright, desktop + Pixel 7)
There are two viewers and they behave differently:
ImageViewer<img>(fixed)role=dialog aria-modal"Media viewer"Fixed (
53823f54): lightbox now focuses itself on open so ←/→/Esc/+/- work immediately; the timeline viewer gained + / = / - / 0, double-click 1×↔2×,role=dialog aria-modallabelled with the file name, and focuses on open. Escape closes both.Filed: #219 — unify: a timeline image should open the gallery lightbox at that item (dark backdrop, sender/time, prev/next, consistent keys), and add pinch-zoom; the small viewer then only remains for avatars.
Cosmetic seen along the way: the seasonal floating button sits on top of both viewers (#215).