Edits and reactions on a thread root are invisible in the thread panel #12
Closed
opened 2026-09-12 01:50:49 -04:00 by jared
·
0 comments
No Branch/Tag Specified
lotus
update-packages
sw-fix
read-me-update
image-path-changes
dm-calls
fix-2469
renovate/element-hq-element-call-embedded-0.x
renovate/npm-i18next-http-backend-vulnerability
renovate/npm-vite-vulnerability
dev
docs-update
more-theme
fix-257
imporve-thread-reply
revert-2402-improve-menu-congestion
mxidColor-toggle
update-sw-main-msg
v4.11.1
v4.10.5
v4.10.4
v4.10.3
v4.10.2
v4.10.1
v4.10.0
v4.9.1
v4.9.0
v4.8.1
v4.8.0
v4.7.1
v4.7.0
v4.6.0
v4.5.1
v4.5.0
v4.4.0
v4.3.2
v4.3.0
v4.2.3
v4.2.2
v4.2.1
v4.2.0
v4.1.0
v4.0.3
v4.0.0
v3.2.0
v3.1.0
v3.0.0
v2.2.6
v2.2.5
v2.2.4
v2.2.3
v2.2.2
v2.2.1
v2.2.0
v2.1.3
v2.1.2
v2.1.1
v2.1.0
v2.0.4
v2.0.3
v2.0.2
v2.0.1
v2.0.0
v1.8.2
v1.8.1
v1.8.0
v1.7.0
v1.6.1
v1.6.0
v1.5.1
v1.5.0
v1.4.0
v1.3.2
v1.3.1
v1.3.0
v1.2.1
v1.2.0
v1.1.0
v1.0.0
Labels
Clear labels
a11y
area: appearance
area: auth-session
area: build-ci
area: calls
area: desktop
area: media
area: messaging
area: mobile
area: moderation
area: navigation
area: notifications
area: settings
area: threads
bug
dependencies
docs
duplicate
enhancement
help wanted
invalid
needs-human-review
performance
planning
priority: critical
priority: high
priority: low
priority: medium
qa
question
research
security
tech-debt
ux
wontfix
Accessibility: keyboard, screen reader, contrast, motion
Client area: appearance
Client area: auth-session
Client area: build-ci
Client area: calls
Client area: desktop
Client area: media
Client area: messaging
Client area: mobile
Client area: moderation
Client area: navigation
Client area: notifications
Client area: settings
Client area: threads
Something is not working
Third-party package versions and advisories
README / LOTUS_* docs wrong or missing
This issue or pull request already exists
New feature
Need some help
Something is wrong
Re-render storms, leaks, heavy work on hot paths
Data loss, security hole, or crash on a main path
Broken feature or serious usability problem
Minor issue or polish
Wrong behaviour in an edge case or notable degradation
Manual QA: shipped, needs a human in a real environment
More information is needed
XSS, unsafe URLs, data leaks, auth/session
Code health, dead code, fragile patterns
Usability or visual inconsistency
This won't be fixed
Milestone
No items
No Milestone
Audit 2026-09 · High
Projects
Clear projects
No projects
Notifications
Due Date
Dependencies
No dependencies set.
Reference: LotusGuild/cinny#12
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Severity: high · Type: bug · Confidence: high
Location:
src/app/features/room/thread/ThreadTimeline.tsx:718(thread.getUnfilteredTimelineSet()),:660-680(renderMessageContent),:551-570(handleReactionToggle)Problem
The thread panel resolves edits (
getEditedEvent) and reactions (getEventReactions) against the thread's timeline set for every event including the root. PerRoom.eventShouldLiveIn(matrix-js-sdkroom.js:2110), a non-thread relation whose parent is a thread root lives only in the main room timeline — so edits and reactions targeting the root are never in the thread's timeline set. Result: after editing a thread root, the thread panel keeps showing the pre-edit text with no "(edited)" marker; reactions added to the root in the main timeline don't appear in the panel. Clicking the same emoji from inside the panel also can't find your existing reaction (myReactionlookup misses) and sends a duplicatem.reactioninstead of toggling it off.How to trigger
Start a thread, edit the root message and react to it from the main timeline, then open the thread panel.
Suggested fix
For the root event only (and any event whose relations live in the room), read edits/reactions from
room.getUnfilteredTimelineSet(); the simplest fix is to passmEventId === thread.id ? room.getUnfilteredTimelineSet() : thread.getUnfilteredTimelineSet()intogetEditedEvent/getEventReactions/handleReactionToggle.Filed from the September 2026 client audit (branch
lotus@4bea4895).