The #26 fix (a29be795) added useRoomCallPolicy and a "Share your screen?" confirm popover to the app-wide call-status bar, but the in-room CallControls still reads io.lotus.room_quality inline and has its own copy of the confirm dialog. Two implementations of the same policy and dialog will drift.
Suggested fix
Migrate CallControls to useRoomCallPolicy and extract the confirm dialog into one shared component used by both bars.
Follow-up from the September 2026 audit fix rounds.
**Location:** `src/app/features/call/CallControls.tsx` (~L110-118, ~L403-418), `src/app/features/call-status/CallControl.tsx`, `src/app/hooks/useRoomCallPolicy.ts`
### Problem
The #26 fix (a29be795) added `useRoomCallPolicy` and a "Share your screen?" confirm popover to the app-wide call-status bar, but the in-room `CallControls` still reads `io.lotus.room_quality` inline and has its own copy of the confirm dialog. Two implementations of the same policy and dialog will drift.
### Suggested fix
Migrate `CallControls` to `useRoomCallPolicy` and extract the confirm dialog into one shared component used by both bars.
---
_Follow-up from the September 2026 audit fix rounds._
jared
added this to the Audit 2026-09 · Medium & Low milestone 2026-09-12 19:54:07 -04:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Location:
src/app/features/call/CallControls.tsx(~L110-118, ~L403-418),src/app/features/call-status/CallControl.tsx,src/app/hooks/useRoomCallPolicy.tsProblem
The #26 fix (
a29be795) addeduseRoomCallPolicyand a "Share your screen?" confirm popover to the app-wide call-status bar, but the in-roomCallControlsstill readsio.lotus.room_qualityinline and has its own copy of the confirm dialog. Two implementations of the same policy and dialog will drift.Suggested fix
Migrate
CallControlstouseRoomCallPolicyand extract the confirm dialog into one shared component used by both bars.Follow-up from the September 2026 audit fix rounds.