Process: no CODEOWNERS or required review — a single push to lotus deploys to production in ~11 minutes #100

Open
opened 2026-09-12 01:57:47 -04:00 by jared · 0 comments
Owner

Location: repo settings (no branch protection on lotus, no CODEOWNERS), README.md "edit → commit → git push → ~11 min → live"

Problem

This is a deliberate velocity trade-off and may be exactly right for the team size, so this issue is a decision point rather than a defect. As it stands, any collaborator's direct push to lotus reaches every user with no second pair of eyes; combined with the upstream-merge bypass it means production can change with zero review and zero CI.

Suggested fix

At minimum, enable Gitea branch protection on lotus requiring the Build & Quality Checks status to pass before push (this alone closes the cancelled-run and merge-script gaps). Optionally require one approval for changes under src/app/features/call, src/app/utils/searchCache.ts, src/app/state/sessions.ts, and src/client/ — the areas where this audit found the security-relevant bugs — via a CODEOWNERS file.


Filed from the September 2026 client audit (CI pipeline review, branch lotus @ 4bea4895).

**Location:** repo settings (no branch protection on `lotus`, no `CODEOWNERS`), `README.md` "edit → commit → git push → ~11 min → live" ### Problem This is a deliberate velocity trade-off and may be exactly right for the team size, so this issue is a decision point rather than a defect. As it stands, any collaborator's direct push to `lotus` reaches every user with no second pair of eyes; combined with the upstream-merge bypass it means production can change with zero review and zero CI. ### Suggested fix At minimum, enable Gitea branch protection on `lotus` requiring the `Build & Quality Checks` status to pass before push (this alone closes the cancelled-run and merge-script gaps). Optionally require one approval for changes under `src/app/features/call`, `src/app/utils/searchCache.ts`, `src/app/state/sessions.ts`, and `src/client/` — the areas where this audit found the security-relevant bugs — via a `CODEOWNERS` file. --- _Filed from the September 2026 client audit (CI pipeline review, branch `lotus` @ 4bea4895)._
jared added this to the Audit 2026-09 · Medium & Low milestone 2026-09-12 01:57:47 -04:00
jared added the priority: lowtech-debtarea: build-ci labels 2026-09-12 01:57:47 -04:00
jared self-assigned this 2026-09-12 01:57:47 -04:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: LotusGuild/cinny#100