Commit Graph

4 Commits

Author SHA1 Message Date
jared bbf0800c19 fix(ci): disable lines-between-class-members + prefer-arrow-callback for test files
CI / Build & Quality Checks (push) Successful in 10m46s
CI / Trigger Desktop Build (push) Successful in 12s
CI check:eslint failed with 28 errors in two test files: callSounds.test.ts
(lines-between-class-members on mock classes) and lotusDenoiseUtils.test.ts
(prefer-arrow-callback on `function AudioWorkletNode(){}` constructor mocks —
arrows aren't constructable, so auto-fixing would break the test). Both are
stylistic false-positives for test code; relax them in the existing test-file
override next to max-classes-per-file. `npm run check:eslint` now exits 0.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-02 18:27:01 -04:00
jared 6728a1274d chore(a11y): enforce a curated jsx-a11y lint gate in CI (P3-4)
Enables ARIA-correctness rules (aria-props/proptypes/role/unsupported-elements,
role-has/supports-aria-props, no-redundant-roles, anchor/heading-has-content)
+ label-has-associated-control as errors — a regression gate for accessible
names + valid ARIA. control-has-associated-label deliberately NOT enabled (the
repo's <Text as="label" htmlFor> component pattern defeats its static analysis);
the real gaps it surfaced were fixed directly. Also disable max-classes-per-file
for test files (mock classes).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-02 11:45:22 -04:00
Lotus Bot f24dff99ee fix: resolve all ESLint errors and fix CI Prettier failure
- Add jsx-a11y plugin to flat config (fixes definition-not-found errors)
- Turn off stylistic rules (no-console, no-continue, no-restricted-syntax, etc.)
- Downgrade no-explicit-any to warn; configure no-unused-vars to allow _ prefix
- Extend no-undef: off to .tsx files (TypeScript DOM types like PermissionName)
- Fix INEFFECTIVE_DYNAMIC_IMPORT: make HomeCreateRoom and Create lazy in Router
- Fix audioRef.current capture in CallEmbedProvider cleanup effect
- Fix JSX comment syntax in GifPicker (// → {/* */})
- Remove unused imports across 8 files
- Fix react-hooks/exhaustive-deps: add/remove missing/unnecessary deps
- Fix no-bitwise and no-shadow in RoomTimeline with eslint-disable comments
- Fix no-useless-concat in lotus-terminal.css.ts
- Fix Prettier formatting on src/index.tsx (extra blank line from prev commit)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-22 17:17:26 -04:00
Lotus Bot d6ae29f8f3 chore: upgrade ESLint 8→9 with flat config migration
- eslint 8.57.1 to 9.39.4
- @typescript-eslint/eslint-plugin 7.18.0 to 8.59.4
- @typescript-eslint/parser 7.18.0 to 8.59.4
- globals 11.12.0 to 17.6.0
- @eslint/eslintrc and @eslint/js added for FlatCompat
- Replace .eslintrc.cjs + .eslintignore with eslint.config.mjs
- Use flat configs for react, react-hooks, typescript-eslint directly
- FlatCompat only for airbnb-base (no flat config support yet)
- Fix no-unused-vars override from airbnb and react/display-name: off

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-22 13:13:30 -04:00