LotusGuild/cinny
3
0
Fork 0
Code Issues 41 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

fix(embeds): stop building broken redd.it / i.redd.it Reddit embeds

Browse Source 
embed.reddit.com only renders the /r/<sub>/comments/<id> path (verified against
reddit's embed widgets.js + curl: frame-ancestors * , no X-Frame-Options, so
iframing itself is fine). But getRedditPostEmbed built a bare
embed.reddit.com/comments/<id> for redd.it short links — which serves a 'not
found' page — and the i. host strip routed i.redd.it/*.jpg image links into the
same branch. Returning a (broken) URL also suppressed renderContent's og:url
fallback that would resolve the short link to its canonical /r/<sub>/... form.

Fix: getRedditPostEmbed returns null for any non-reddit.com host, so redd.it /
i.redd.it / v.redd.it fall through to the og:url fallback (working embed or a
normal preview card, never a blank 'not found' iframe). The reddit.com post path
is unchanged. Tests updated (22 pass).

Note: the live 'broken' symptom is mostly the deploy gap — live still runs the
old www.redditmedia.com embed code while the live CSP only allows
embed.reddit.com; deploying the current lotus branch (which emits
embed.reddit.com) resolves it.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
jared
2026-07-07 20:09:05 -04:00
co-authored by Claude Opus 4.8
parent 0c6003fb87
commit fd87a27251
2 changed files with 14 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/app/utils/videoEmbed.ts
+8 -8
View File
@@ -344,8 +344,9 @@ export function getInstagramEmbed(url: string): string | null {
}
}
// --- Reddit (post embed via redditmedia — bypasses the homeserver's blocked
// preview fetch, which Reddit serves a bot-check "please wait" page to) ---
// --- Reddit (post embed via embed.reddit.com — reddit's own oEmbed widget host;
// www.redditmedia.com now 301s here. Bypasses the homeserver's blocked preview
// fetch, which Reddit serves a bot-check "please wait" page to) ---
const REDDIT_EMBED_QS = '?ref_source=embed&ref=share&embed=true&theme=dark';
@@ -353,15 +354,14 @@ export function getRedditPostEmbed(url: string): string | null {
try {
const u = new URL(url);
const h = u.hostname.replace(/^(www|old|new|np|i)\./, '');
// redd.it/<id> short link → reddit.com/comments/<id> (no subreddit needed).
if (h === 'redd.it') {
const id = u.pathname.replace(/^\/+|\/+$/g, '').split('/')[0];
return id ? `https://embed.reddit.com/comments/${id}/${REDDIT_EMBED_QS}` : null;
}
// embed.reddit.com ONLY renders the /r/<sub>/comments/<id> path (verified against
// reddit's own embed widgets.js). A bare /comments/<id> — all we could build from a
// redd.it short link or an i./v.redd.it media host — serves a "not found" page, so
// return null for those and let the caller's og:url fallback resolve the canonical
// /r/<sub>/comments/<id> URL (from the redirect) before re-parsing into a real embed.
if (h !== 'reddit.com') return null;
const m = u.pathname.match(/^\/r\/([A-Za-z0-9_]+)\/comments\/([A-Za-z0-9]+)/);
if (!m) return null;
// embed.reddit.com is the current host (www.redditmedia.com now 301s here).
return `https://embed.reddit.com/r/${m[1]}/comments/${m[2]}/${REDDIT_EMBED_QS}`;
} catch {
return null;