From f5ee3c0d0e8e21919b688f9b0857c45f39d34225 Mon Sep 17 00:00:00 2001 From: Jared Vititoe Date: Wed, 23 Sep 2026 15:39:26 -0400 Subject: [PATCH] fix(assets): rename Lotus.png so it no longer collides with lotus.png (#229) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit public/res/ carried two DIFFERENT files whose names differ only in case — Lotus.png (19 897 B, the 256px logo used by the welcome page, auth layout, OIDC config and About) and lotus.png (2 073 B, the notification icon). Windows and macOS filesystems are case-insensitive, so a checkout there collapses them into one path: one of the two references then resolves to the wrong bytes or to nothing, which is why the desktop client's home logo rendered as alt text from http://localhost:44548/public/res/Lotus.png. Renamed the logo to lotus-logo.png and updated its four references; verified no case-only filename collisions remain anywhere in the repo, and that both logos still load (256x256 on the welcome page and About). Co-Authored-By: Claude Opus 5 Claude-Session: https://claude.ai/code/session_01PPmy3tPq869XDW4njjVaKA --- public/res/{Lotus.png => lotus-logo.png} | Bin src/app/features/settings/about/About.tsx | 2 +- src/app/pages/auth/AuthLayout.tsx | 2 +- src/app/pages/auth/oidc/oidcConfig.ts | 2 +- src/app/pages/client/WelcomePage.tsx | 2 +- 5 files changed, 4 insertions(+), 4 deletions(-) rename public/res/{Lotus.png => lotus-logo.png} (100%) diff --git a/public/res/Lotus.png b/public/res/lotus-logo.png similarity index 100% rename from public/res/Lotus.png rename to public/res/lotus-logo.png diff --git a/src/app/features/settings/about/About.tsx b/src/app/features/settings/about/About.tsx index 0ac7b51e5..082317d37 100644 --- a/src/app/features/settings/about/About.tsx +++ b/src/app/features/settings/about/About.tsx @@ -9,7 +9,7 @@ import pkg from '../../../../../package.json'; import { clearCacheAndReload } from '../../../../client/initMatrix'; import { useMatrixClient } from '../../../hooks/useMatrixClient'; -const LotusLogo = withOriginBaseUrl(getOriginBaseUrl(), '/public/res/Lotus.png'); +const LotusLogo = withOriginBaseUrl(getOriginBaseUrl(), '/public/res/lotus-logo.png'); type MSC1929Contact = { matrix_id?: string; diff --git a/src/app/pages/auth/AuthLayout.tsx b/src/app/pages/auth/AuthLayout.tsx index a448f75b4..6ce1674fb 100644 --- a/src/app/pages/auth/AuthLayout.tsx +++ b/src/app/pages/auth/AuthLayout.tsx @@ -31,7 +31,7 @@ import { AuthFlowsProvider } from '../../hooks/useAuthFlows'; import { AuthServerProvider } from '../../hooks/useAuthServer'; import { tryDecodeURIComponent } from '../../utils/dom'; -const LotusLogo = withOriginBaseUrl(getOriginBaseUrl(), '/public/res/Lotus.png'); +const LotusLogo = withOriginBaseUrl(getOriginBaseUrl(), '/public/res/lotus-logo.png'); const currentAuthPath = (pathname: string): string => { if (matchPath(LOGIN_PATH, pathname)) { diff --git a/src/app/pages/auth/oidc/oidcConfig.ts b/src/app/pages/auth/oidc/oidcConfig.ts index 0e4ff4e4e..73c5e2338 100644 --- a/src/app/pages/auth/oidc/oidcConfig.ts +++ b/src/app/pages/auth/oidc/oidcConfig.ts @@ -2,7 +2,7 @@ import type { OidcRegistrationClientMetadata } from 'matrix-js-sdk'; import { OIDC_CALLBACK_PATH } from '../../paths'; import { getOriginBaseUrl, withOriginBaseUrl } from '../../pathUtils'; -const LotusLogo = withOriginBaseUrl(getOriginBaseUrl(), '/public/res/Lotus.png'); +const LotusLogo = withOriginBaseUrl(getOriginBaseUrl(), '/public/res/lotus-logo.png'); /** * Absolute URL the OIDC provider redirects back to after authorization. diff --git a/src/app/pages/client/WelcomePage.tsx b/src/app/pages/client/WelcomePage.tsx index f1498f9cb..c147d3cac 100644 --- a/src/app/pages/client/WelcomePage.tsx +++ b/src/app/pages/client/WelcomePage.tsx @@ -4,7 +4,7 @@ import { Page, PageHero, PageHeroSection } from '../../components/page'; import { getOriginBaseUrl, withOriginBaseUrl } from '../pathUtils'; import pkg from '../../../../package.json'; -const LotusLogo = withOriginBaseUrl(getOriginBaseUrl(), '/public/res/Lotus.png'); +const LotusLogo = withOriginBaseUrl(getOriginBaseUrl(), '/public/res/lotus-logo.png'); export function WelcomePage() { return (