DP16: add typed get/setAccountData helpers, remove ~19 any-casts

Add centralized typed helpers in src/app/utils/accountData.ts:
- getAccountData<T>(mx, eventType): T | undefined (returns content)
- setAccountData<T>(mx, eventType, content): Promise<void>

These wrap the single `as any` cast needed because matrix-js-sdk's typed
overloads reject the fork's custom account-data event names. Every call site
now stays fully typed on its content shape.

Route all account-data reads/writes that previously used
`(mx as any).getAccountData/setAccountData` or `mx.getAccountData(... as any)`
through the helpers (or, where a MatrixEvent is needed, through the existing
utils/room.ts getAccountData whose param is widened to accept string keys).
No behavior change: same event types, same content shapes.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

src/app/features/lobby/Lobby.tsx

@@ -41,6 +41,7 @@ import { StateEvent } from '../../../types/matrix/room';
 import { CanDropCallback, useDnDMonitor } from './DnD';
 import { ASCIILexicalTable, orderKeys } from '../../utils/ASCIILexicalTable';
 import { getStateEvent } from '../../utils/room';
+import { setAccountData } from '../../utils/accountData';
 import { useClosedLobbyCategoriesAtom } from '../../state/hooks/closedLobbyCategories';
 import {
   makeCinnySpacesContent,
@@ -427,7 +428,7 @@ export function Lobby() {
         newItems.push(rId);
       }
       const newSpacesContent = makeCinnySpacesContent(mx, newItems);
-      mx.setAccountData(AccountDataEvent.CinnySpaces as any, newSpacesContent as any);
+      setAccountData(mx, AccountDataEvent.CinnySpaces, newSpacesContent);
     },
     [mx, sidebarItems, sidebarSpaces],
   );

src/app/features/room-nav/RoomNavItem.tsx

@@ -34,6 +34,7 @@ import { NavItem, NavItemContent, NavItemOptions, NavLink } from '../../componen
 import { UnreadBadge, UnreadBadgeCenter } from '../../components/unread-badge';
 import { RoomAvatar, RoomIcon } from '../../components/room-avatar';
 import { getDirectRoomAvatarUrl, getRoomAvatarUrl, getStateEvent } from '../../utils/room';
+import { setAccountData } from '../../utils/accountData';
 import { nameInitials } from '../../utils/common';
 import { useMatrixClient } from '../../hooks/useMatrixClient';
 import { useRoomUnread } from '../../state/hooks/unread';
@@ -127,11 +128,9 @@ function RenameRoomDialog({ room, onClose }: RenameRoomDialogProps) {
     const existing = getLocalRoomNamesContent(mx);
     if (newName === '') {
       const { [room.roomId]: _removed, ...rest } = existing.rooms;
-      // eslint-disable-next-line @typescript-eslint/no-explicit-any
-      (mx as any).setAccountData(LOCAL_ROOM_NAMES_KEY, { rooms: rest });
+      setAccountData(mx, LOCAL_ROOM_NAMES_KEY, { rooms: rest });
     } else {
-      // eslint-disable-next-line @typescript-eslint/no-explicit-any
-      (mx as any).setAccountData(LOCAL_ROOM_NAMES_KEY, {
+      setAccountData(mx, LOCAL_ROOM_NAMES_KEY, {
         rooms: { ...existing.rooms, [room.roomId]: newName },
       });
     }
@@ -141,8 +140,7 @@ function RenameRoomDialog({ room, onClose }: RenameRoomDialogProps) {
   const handleClear = useCallback(() => {
     const existing = getLocalRoomNamesContent(mx);
     const { [room.roomId]: _removed, ...rest } = existing.rooms;
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    (mx as any).setAccountData(LOCAL_ROOM_NAMES_KEY, { rooms: rest });
+    setAccountData(mx, LOCAL_ROOM_NAMES_KEY, { rooms: rest });
     onClose();
   }, [mx, room.roomId, onClose]);
 

src/app/features/settings/account/Profile.tsx

@@ -35,6 +35,7 @@ import { SequenceCard } from '../../../components/sequence-card';
 import { SequenceCardStyle } from '../styles.css';
 import { SettingTile } from '../../../components/setting-tile';
 import { useMatrixClient } from '../../../hooks/useMatrixClient';
+import { getAccountData, setAccountData } from '../../../utils/accountData';
 import { presenceStateFromSetting } from '../../../hooks/usePresenceUpdater';
 import { useSetting } from '../../../state/hooks/settings';
 import { settingsAtom } from '../../../state/settings';
@@ -725,9 +726,7 @@ function ProfileTimezone() {
   const [savedTimezone, setSavedTimezone] = useState<string>('');
 
   useEffect(() => {
-    const cached = mx
-      .getAccountData('im.lotus.timezone' as any)
-      ?.getContent<{ timezone: string }>();
+    const cached = getAccountData<{ timezone: string }>(mx, 'im.lotus.timezone');
     if (cached?.timezone) {
       setTimezone(cached.timezone);
       setSavedTimezone(cached.timezone);
@@ -754,7 +753,7 @@ function ProfileTimezone() {
         Promise.all([
           // Self-fallback: account data is readable by useExtendedProfile for the
           // own user even on servers without extended-profile (m.tz) support.
-          (mx as any).setAccountData('im.lotus.timezone', { timezone: value }),
+          setAccountData(mx, 'im.lotus.timezone', { timezone: value }),
           // Mirror the pronouns write path so OTHER users can read the timezone
           // via the m.tz profile field. Best-effort: standard Synapse rejects
           // unknown profile fields, so a failure here must not fail the save.

src/app/features/settings/developer-tools/DevelopTools.tsx

@@ -12,6 +12,7 @@ import {
   AccountDataSubmitCallback,
 } from '../../../components/AccountDataEditor';
 import { copyToClipboard } from '../../../utils/dom';
+import { getAccountData, setAccountData } from '../../../utils/accountData';
 import { AccountData } from './AccountData';
 import { CryptoDiagnostics } from '../developer/CryptoDiagnostics';
 
@@ -26,7 +27,7 @@ export function DeveloperTools({ requestClose }: DeveloperToolsProps) {
 
   const submitAccountData: AccountDataSubmitCallback = useCallback(
     async (type, content) => {
-      await (mx as any).setAccountData(type, content);
+      await setAccountData(mx, type, content);
     },
     [mx],
   );
@@ -36,7 +37,7 @@ export function DeveloperTools({ requestClose }: DeveloperToolsProps) {
       <AccountDataEditor
         type={accountDataType ?? undefined}
         content={
-          accountDataType ? (mx as any).getAccountData(accountDataType)?.getContent() : undefined
+          accountDataType ? getAccountData<object>(mx, accountDataType) : undefined
         }
         submitChange={submitAccountData}
         requestClose={() => setAccountDataType(undefined)}

src/app/features/settings/emojis-stickers/GlobalPacks.tsx

@@ -1,4 +1,4 @@
-import { MatrixEvent, Room } from 'matrix-js-sdk';
+import { Room } from 'matrix-js-sdk';
 import React, { MouseEventHandler, useCallback, useEffect, useMemo, useState } from 'react';
 import {
   Box,
@@ -41,6 +41,7 @@ import {
 import { LineClamp2 } from '../../../styles/Text.css';
 import { allRoomsAtom } from '../../../state/room-list/roomList';
 import { AccountDataEvent } from '../../../../types/matrix/accountData';
+import { getAccountData, setAccountData } from '../../../utils/accountData';
 import { AsyncStatus, useAsyncCallback } from '../../../hooks/useAsyncCallback';
 import { stopPropagation } from '../../../utils/keyboard';
 
@@ -303,9 +304,7 @@ export function GlobalPacks({ onViewPack }: GlobalPacksProps) {
   const [applyState, applyChanges] = useAsyncCallback(
     useCallback(async () => {
       const content =
-        (
-          (mx as any).getAccountData(AccountDataEvent.PoniesEmoteRooms) as MatrixEvent | undefined
-        )?.getContent<EmoteRoomsContent>() ?? {};
+        getAccountData<EmoteRoomsContent>(mx, AccountDataEvent.PoniesEmoteRooms) ?? {};
       const updatedContent: EmoteRoomsContent = JSON.parse(JSON.stringify(content));
 
       selectedPacks.forEach((addr) => {
@@ -322,7 +321,7 @@ export function GlobalPacks({ onViewPack }: GlobalPacksProps) {
         }
       });
 
-      await (mx as any).setAccountData(AccountDataEvent.PoniesEmoteRooms, updatedContent);
+      await setAccountData(mx, AccountDataEvent.PoniesEmoteRooms, updatedContent);
     }, [mx, selectedPacks, removedPacks]),
   );