fix: low-tail correctness — thread notifs, call audio, OIDC expiry
Verify-then-fix batch of minor bugs; each staged diff reviewed by 2 agents (both SHIP). Two listed items (N6 receipt-avatar refresh, H10 room-name length reject) were already handled and left unchanged. Threads: - T5: a just-sent reply no longer under-notifies — `participated` also checks the local thread timeline for our own events, since the server-bundle `hasCurrentUserParticipated` lags. - T6: a room set to "Mentions & Keywords only" no longer over-notifies Default thread replies — new `roomMentionsOnly` gate (behavior-identical when false; +4 unit tests). - T7: thread-mode account-data writes are serialized with content carried forward (setAccountData is a bare PUT whose result lags the /sync echo, so plain serialization wouldn't stop the lost update); carry only on success. Calls / audio: - C-L2: a real incoming ring cancels a lingering Settings ringtone preview. - C-L3: the ringtone AudioContext is primed on the first page gesture (via the always-mounted CallEmbedProvider) so the first ring after a cold load isn't silent. - C-L5: useCallSpeakers depends on a stable boolean, so the tile MutationObserver + io.lotus.call_state subscription aren't rebuilt on every membership change. Crypto: - F5: the OIDC refresher forwards the freshly-refreshed token expiry (passed on the tokens object at runtime) as expiresInMs, so the persisted expiresAt no longer goes stale across reloads. Gates: tsc 0, eslint 0, prettier clean, 860/860 tests, build ok. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
@@ -106,8 +106,16 @@ export function shouldNotifyThreadReply(input: {
|
||||
highlight: boolean;
|
||||
notify: boolean;
|
||||
roomMuted: boolean;
|
||||
/**
|
||||
* The room is set to "Mentions & Keywords only" (room push rule, not the
|
||||
* global default). When the thread mode is Default, this makes only
|
||||
* highlights notify — honoring the room preference instead of the
|
||||
* all/participating default (which otherwise over-notifies). An explicit
|
||||
* per-thread All/MentionsOnly/Mute override still wins.
|
||||
*/
|
||||
roomMentionsOnly: boolean;
|
||||
}): ThreadNotifyDecision {
|
||||
const { mode, defaultBehavior, participated, highlight, roomMuted } = input;
|
||||
const { mode, defaultBehavior, participated, highlight, roomMuted, roomMentionsOnly } = input;
|
||||
|
||||
if (roomMuted) return 'none';
|
||||
if (mode === ThreadNotificationMode.Mute) return 'none';
|
||||
@@ -120,13 +128,13 @@ export function shouldNotifyThreadReply(input: {
|
||||
return highlight ? 'loud' : 'none';
|
||||
}
|
||||
|
||||
// ThreadNotificationMode.Default
|
||||
if (defaultBehavior === 'all') {
|
||||
return highlight ? 'loud' : 'notify';
|
||||
}
|
||||
|
||||
// defaultBehavior === 'participating'
|
||||
// ThreadNotificationMode.Default — highlights always notify loudly.
|
||||
if (highlight) return 'loud';
|
||||
// Room is "Mentions & Keywords only": a Default thread inherits that, so a
|
||||
// non-highlight reply does not notify.
|
||||
if (roomMentionsOnly) return 'none';
|
||||
if (defaultBehavior === 'all') return 'notify';
|
||||
// defaultBehavior === 'participating'
|
||||
return participated ? 'notify' : 'none';
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user