fix: low-tail correctness — thread notifs, call audio, OIDC expiry
Verify-then-fix batch of minor bugs; each staged diff reviewed by 2 agents (both SHIP). Two listed items (N6 receipt-avatar refresh, H10 room-name length reject) were already handled and left unchanged. Threads: - T5: a just-sent reply no longer under-notifies — `participated` also checks the local thread timeline for our own events, since the server-bundle `hasCurrentUserParticipated` lags. - T6: a room set to "Mentions & Keywords only" no longer over-notifies Default thread replies — new `roomMentionsOnly` gate (behavior-identical when false; +4 unit tests). - T7: thread-mode account-data writes are serialized with content carried forward (setAccountData is a bare PUT whose result lags the /sync echo, so plain serialization wouldn't stop the lost update); carry only on success. Calls / audio: - C-L2: a real incoming ring cancels a lingering Settings ringtone preview. - C-L3: the ringtone AudioContext is primed on the first page gesture (via the always-mounted CallEmbedProvider) so the first ring after a cold load isn't silent. - C-L5: useCallSpeakers depends on a stable boolean, so the tile MutationObserver + io.lotus.call_state subscription aren't rebuilt on every membership change. Crypto: - F5: the OIDC refresher forwards the freshly-refreshed token expiry (passed on the tokens object at runtime) as expiresInMs, so the persisted expiresAt no longer goes stale across reloads. Gates: tsc 0, eslint 0, prettier clean, 860/860 tests, build ok. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
@@ -644,13 +644,24 @@ function MessageNotifications() {
|
||||
const content = threadPrefs;
|
||||
const mode = getThreadNotificationMode(content, room.roomId, thread.id);
|
||||
const actions = mx.getPushActionsForEvent(mEvent);
|
||||
// `hasCurrentUserParticipated` is derived from the server thread bundle,
|
||||
// which lags a reply we just sent — so also treat any of our own events
|
||||
// already in the thread timeline as participation (T5: avoid under-notify).
|
||||
const myUserId = mx.getUserId();
|
||||
const participated =
|
||||
thread.hasCurrentUserParticipated ||
|
||||
thread.timeline.some((e) => e.getSender() === myUserId);
|
||||
const roomNotifType = getNotificationType(mx, room.roomId);
|
||||
const decision = shouldNotifyThreadReply({
|
||||
mode,
|
||||
defaultBehavior: content.default ?? THREAD_NOTIFICATIONS_FALLBACK_BEHAVIOR,
|
||||
participated: thread.hasCurrentUserParticipated,
|
||||
participated,
|
||||
highlight: !!actions?.tweaks?.highlight,
|
||||
notify: !!actions?.notify,
|
||||
roomMuted: getNotificationType(mx, room.roomId) === NotificationType.Mute,
|
||||
roomMuted: roomNotifType === NotificationType.Mute,
|
||||
// T6: honor a room-level "Mentions & Keywords only" setting for Default
|
||||
// threads instead of over-notifying every participated reply.
|
||||
roomMentionsOnly: roomNotifType === NotificationType.MentionsAndKeywords,
|
||||
});
|
||||
if (decision === 'none') return;
|
||||
|
||||
|
||||
Reference in New Issue
Block a user