diff --git a/LOTUS_BUGS.md b/LOTUS_BUGS.md index 1f054267c..6ded0dfe6 100644 --- a/LOTUS_BUGS.md +++ b/LOTUS_BUGS.md @@ -376,8 +376,8 @@ This document tracks identified bugs, edge cases, and architectural discrepancie **N53 — PTT Badge (Lotus Terminal path): Raw `
` tree with `--lt-*` CSS vars instead of folds ``** -- **File:** `src/app/features/call/CallControls.tsx`, lines 242–282 -- **Status:** **OPEN** +- **File:** `src/app/features/call/CallControls.tsx` +- **Status:** **FIXED** (`50076962`) — removed the `lotusTerminal` branch entirely; the PTT badge is now the single folds `` path for all themes (TDS styling still flows through the CSS-variable layer over the Chip). Dropped the now-unused `lotusTerminal` read. Build-verified; visual parity to confirm only if you specifically used the terminal-mode PTT look. - **Issue:** When `lotusTerminal` is true the PTT badge renders as a bare `` with inline styles referencing `--lt-accent-green-dim`, `--lt-accent-green-border`, `--lt-accent-green` — variables absent outside TDS mode — hardcoded rem padding, `borderRadius: '99px'` (non-token), a raw monospace `fontFamily` string, non-token `letterSpacing`, and a raw `animation:` CSS string for the live-pulse dot. The live `●` dot is a raw `` with inline style. - **Root Cause:** Two entirely separate component trees for the same badge depending on a theme boolean. The non-terminal path (lines 284–301) uses the correct ``. - **Fix:** Remove the terminal branch. The standard `` path already exists and TDS theming can be applied via the CSS variable layer without a separate component tree. @@ -440,8 +440,8 @@ This document tracks identified bugs, edge cases, and architectural discrepancie | N78 | HasLink Chip Active Color | `SearchFilters.tsx` | 755 | `HasLink` active state uses `variant="Primary"` (blue); all boolean scope-toggle chips in the same bar use `variant="Success"` (green) with `outlined` — **FIXED**: changed to `variant={containsUrl ? 'Success' : 'SurfaceVariant'} outlined={!!containsUrl}` | `variant="Success" outlined` is the established active-state pattern for boolean toggles in the filter bar | | N79 | Server Notice Chip Radii | `RoomViewHeader.tsx` | 570 | `` — `Pill` radii on a room-type label — **FIXED**: changed to `radii="300"` | Room/space type labels in lobby (`RoomItem.tsx:83`, `SpaceItem.tsx:63`) use `radii="300"`; `radii="Pill"` is for filter/tag chips only | | N80 | Server Support Contact Layout | `About.tsx` | 172–239 | Homeserver support contacts rendered as raw `` with `` pairs — custom label/link layout — **WON'T FIX (deliberate)**: a contact is `role → {matrix_id?, email?, …}` (one-to-many links per role), which doesn't map onto `SettingTile`'s single `title`/`description`/`after` slots without contortion. The current layout already uses folds `Box`/`Text`/`SequenceCard` + tokens and `Text as="a"` (a valid folds pattern); no undefined vars or raw HTML chrome. | All other `` content in `About.tsx` and `General.tsx` uses `` as the content unit | -| N81 | Background Picker Grid — No Responsive Layout | `General.tsx` | 1707–1742 | Fixed `width: toRem(76)` flex-wrap cells with no `minWidth` floor or CSS grid `auto-fill` — SeasonalBgGrid's 13 items produce a visually lopsided orphan last row at any viewport width | Cinny's native grids use `grid-template-columns: repeat(auto-fill, minmax(N, 1fr))` or equivalent for responsive fill | -| N82 | Join/Leave Sounds Auto-Preview | `General.tsx` | 1592–1609 | Selecting a sound in the dropdown immediately plays a preview, but no UI affordance (button label, description text, or "▶ Preview" button) communicates this to the user | Settings tiles with side effects on selection (theme picker, chat background) show a live visual preview or a dedicated control explaining the side effect | +| N81 | Background Picker Grid — No Responsive Layout | `General.tsx` | 1707–1742 | Fixed `width: toRem(76)` flex-wrap cells with no `minWidth` floor or CSS grid `auto-fill` — SeasonalBgGrid's 13 items produce a visually lopsided orphan last row at any viewport width — **FIXED** (`50076962`): both `ChatBgGrid` and `SeasonalBgGrid` containers switched to `display: grid; grid-template-columns: repeat(auto-fill, minmax(toRem(76), 1fr))`, so swatches fill each row evenly | Cinny's native grids use `grid-template-columns: repeat(auto-fill, minmax(N, 1fr))` or equivalent for responsive fill | +| N82 | Join/Leave Sounds Auto-Preview | `General.tsx` | 1592–1609 | Selecting a sound in the dropdown immediately plays a preview, but no UI affordance communicates this to the user — **FIXED**: the tile description now reads "…Selecting an option plays a preview." (the same affordance was applied to the new Ringtone selector) | Settings tiles with side effects on selection (theme picker, chat background) show a live visual preview or a dedicated control explaining the side effect | --- diff --git a/LOTUS_TESTING.md b/LOTUS_TESTING.md index 246997944..c5dc098d5 100644 --- a/LOTUS_TESTING.md +++ b/LOTUS_TESTING.md @@ -254,6 +254,11 @@ In Settings → Appearance: 2. Pick a **seasonal theme** → confirm the **chat background** auto-clears to none. 3. (Edge) If you have old data with both set, after reload only one should visibly apply (no double-overlay clutter). +### F3. Background / seasonal picker grid layout (N81) + +In Settings → Appearance, look at the **Chat Background** and **Seasonal Theme** swatch grids; resize the window narrow→wide. +**Expected:** swatches reflow to fill each row evenly (responsive grid), with no lopsided/orphaned last row at any width. + --- ## G. Calls — additional unverified (👥 2 people) @@ -271,6 +276,11 @@ In a call with at least one other person, pop out the **Picture-in-Picture** min 1. In a **camera-only** call (no screenshare), confirm the **Fullscreen** button is available (previously only showed during screenshare). 2. Use **MemberGlance → Focus camera** to full-screen/spotlight a specific person's camera. (Overlaps **A5**; if you've done A5 you can skip.) +### G3. PTT badge renders on all themes (N53) + +Enable **Push-to-talk** (Settings → Calls) and join a call. Hold the PTT key. +**Expected:** the floating PTT badge above the controls shows "PTT — Hold KEY" when idle and "● Live" (green) while held — on **both** a default theme and Lotus Terminal (it's now a single folds Chip; the old terminal-only variant was removed). + --- ## H. Media / performance (needs a room with many images)