LotusGuild/cinny
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(a11y): semantic headings, htmlFor/id associations, remove duplicate aria-labels

Browse Source 
H-tag: add as=h1/h2 to dialog/UIA/auth headings (21 components)
Label: add htmlFor/id to PasswordRegisterForm (5 pairs) and PasswordResetForm (3 pairs)
Dupe: remove duplicate aria-label from Controls.tsx screenshare button, MembersDrawer, Members, RoomInput

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Lotus Bot
2026-05-21 15:36:59 -04:00
parent 09905828ef
commit 689805ca6e
24 changed files with 37 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/app/components/DeviceVerification.tsx
+1 -1
View File
@@ -259,7 +259,7 @@ export function DeviceVerification({ request, onExit }: DeviceVerificationProps)
<Dialog variant="Surface">
<Header style={DialogHeaderStyles} variant="Surface" size="500">
<Box grow="Yes">
<Text size="H4">Device Verification</Text>
<Text as="h2" size="H4">Device Verification</Text>
</Box>
<IconButton size="300" radii="300" onClick={handleCancel} aria-label="Cancel verification">
<Icon src={Icons.Cross} />
src/app/components/DeviceVerificationSetup.tsx
+2 -2
View File
@@ -299,7 +299,7 @@ export const DeviceVerificationSetup = forwardRef<HTMLDivElement, DeviceVerifica
size="500"
>
<Box grow="Yes">
<Text size="H4">Setup Device Verification</Text>
<Text as="h2" size="H4">Setup Device Verification</Text>
</Box>
<IconButton size="300" radii="300" onClick={onCancel} aria-label="Cancel">
<Icon src={Icons.Cross} />
@@ -334,7 +334,7 @@ export const DeviceVerificationReset = forwardRef<HTMLDivElement, DeviceVerifica
size="500"
>
<Box grow="Yes">
<Text size="H4">Reset Device Verification</Text>
<Text as="h2" size="H4">Reset Device Verification</Text>
</Box>
<IconButton size="300" radii="300" onClick={onCancel} aria-label="Cancel">
<Icon src={Icons.Cross} />
src/app/components/LogoutDialog.tsx
+1 -1
View File
@@ -43,7 +43,7 @@ export const LogoutDialog = forwardRef<HTMLDivElement, LogoutDialogProps>(
size="500"
>
<Box grow="Yes">
<Text size="H4">Logout</Text>
<Text as="h2" size="H4">Logout</Text>
</Box>
</Header>
<Box style={{ padding: config.space.S400 }} direction="Column" gap="400">
src/app/components/join-address-prompt/JoinAddressPrompt.tsx
+1 -1
View File
@@ -80,7 +80,7 @@ export function JoinAddressPrompt({ onOpen, onCancel }: JoinAddressProps) {
size="500"
>
<Box grow="Yes">
<Text size="H4">Join with Address</Text>
<Text as="h2" size="H4">Join with Address</Text>
</Box>
<IconButton size="300" onClick={onCancel} radii="300" aria-label="Cancel">
<Icon src={Icons.Cross} />
src/app/components/leave-room-prompt/LeaveRoomPrompt.tsx
+1 -1
View File
@@ -66,7 +66,7 @@ export function LeaveRoomPrompt({ roomId, onDone, onCancel }: LeaveRoomPromptPro
size="500"
>
<Box grow="Yes">
<Text size="H4" id="leave-room-dialog-title">Leave Room</Text>
<Text as="h2" size="H4" id="leave-room-dialog-title">Leave Room</Text>
</Box>
<IconButton size="300" onClick={onCancel} radii="300" aria-label="Cancel">
<Icon src={Icons.Cross} />
src/app/components/leave-space-prompt/LeaveSpacePrompt.tsx
+1 -1
View File
@@ -66,7 +66,7 @@ export function LeaveSpacePrompt({ roomId, onDone, onCancel }: LeaveSpacePromptP
size="500"
>
<Box grow="Yes">
<Text size="H4">Leave Space</Text>
<Text as="h2" size="H4">Leave Space</Text>
</Box>
<IconButton size="300" onClick={onCancel} radii="300" aria-label="Cancel">
<Icon src={Icons.Cross} />
src/app/components/room-topic-viewer/RoomTopicViewer.tsx
+1 -1
View File
@@ -23,7 +23,7 @@ export const RoomTopicViewer = as<
>
<Header className={css.ModalHeader} variant="Surface" size="500">
<Box grow="Yes">
<Text size="H4" truncate id="room-topic-title">
<Text as="h2" size="H4" truncate id="room-topic-title">
{name}
</Text>
</Box>
src/app/components/uia-stages/DummyStage.tsx
+1 -1
View File
@@ -18,7 +18,7 @@ function DummyErrorDialog({
<Dialog>
<Box style={{ padding: config.space.S400 }} direction="Column" gap="400">
<Box direction="Column" gap="100">
<Text size="H4">{title}</Text>
<Text as="h2" size="H4">{title}</Text>
<Text>{message}</Text>
</Box>
<Button variant="Critical" onClick={onRetry}>
src/app/components/uia-stages/EmailStage.tsx
+2 -2
View File
@@ -37,7 +37,7 @@ function EmailErrorDialog({
gap="400"
>
<Box direction="Column" gap="100">
<Text size="H4">{title}</Text>
<Text as="h2" size="H4">{title}</Text>
<Text>{message}</Text>
<Text as="label" htmlFor="retryEmailInput" size="L400" style={{ paddingTop: config.space.S400 }}>
Email
@@ -141,7 +141,7 @@ export function EmailStageDialog({
<Dialog>
<Box style={{ padding: config.space.S400 }} direction="Column" gap="400">
<Box direction="Column" gap="100">
<Text size="H4">Verification Request Sent</Text>
<Text as="h2" size="H4">Verification Request Sent</Text>
<Text>{`Please check your email "${emailTokenState.data.email}" and validate before continuing further.`}</Text>
{errorCode && (
src/app/components/uia-stages/PasswordStage.tsx
+1 -1
View File
@@ -43,7 +43,7 @@ export function PasswordStage({
size="500"
>
<Box grow="Yes">
<Text size="H4">Account Password</Text>
<Text as="h2" size="H4">Account Password</Text>
</Box>
<IconButton size="300" onClick={onCancel} radii="300" aria-label="Cancel">
<Icon src={Icons.Cross} />
src/app/components/uia-stages/RegistrationTokenStage.tsx
+1 -1
View File
@@ -35,7 +35,7 @@ function RegistrationTokenErrorDialog({
gap="400"
>
<Box direction="Column" gap="100">
<Text size="H4">{title}</Text>
<Text as="h2" size="H4">{title}</Text>
<Text>{message}</Text>
<Text as="label" htmlFor="retryTokenInput" size="L400" style={{ paddingTop: config.space.S400 }}>
Registration Token
src/app/components/uia-stages/SSOStage.tsx
+1 -1
View File
@@ -54,7 +54,7 @@ export function SSOStage({
size="500"
>
<Box grow="Yes">
<Text size="H4">SSO Login</Text>
<Text as="h2" size="H4">SSO Login</Text>
</Box>
<IconButton size="300" onClick={onCancel} radii="300" aria-label="Cancel">
<Icon src={Icons.Cross} />
src/app/components/uia-stages/TermsStage.tsx
+1 -1
View File
@@ -18,7 +18,7 @@ function TermsErrorDialog({
<Dialog>
<Box style={{ padding: config.space.S400 }} direction="Column" gap="400">
<Box direction="Column" gap="100">
<Text size="H4">{title}</Text>
<Text as="h2" size="H4">{title}</Text>
<Text>{message}</Text>
</Box>
<Button variant="Critical" onClick={onRetry}>
src/app/components/user-profile/PowerChip.tsx
+2 -2
View File
@@ -68,7 +68,7 @@ function SelfDemoteAlert({ power, onCancel, onChange }: SelfDemoteAlertProps) {
size="500"
>
<Box grow="Yes">
<Text size="H4">Self Demotion</Text>
<Text as="h2" size="H4">Self Demotion</Text>
</Box>
<IconButton size="300" onClick={onCancel} radii="300" aria-label="Cancel">
<Icon src={Icons.Cross} />
@@ -118,7 +118,7 @@ function SharedPowerAlert({ power, onCancel, onChange }: SharedPowerAlertProps)
size="500"
>
<Box grow="Yes">
<Text size="H4">Shared Power</Text>
<Text as="h2" size="H4">Shared Power</Text>
</Box>
<IconButton size="300" onClick={onCancel} radii="300" aria-label="Cancel">
<Icon src={Icons.Cross} />