LotusGuild/cinny
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(a11y,bug): aria-labels on dialogs/buttons, useAlive GIF guard, typing timer fix

Browse Source 
A11y:
- Add aria-label Close to RoomTopicViewer, ImagePackView close buttons
- Add aria-label Cancel to LeaveRoomPrompt cancel button
- Add aria-label to Send, Reply, Thread, Edit, React, Search, Mute, Download buttons
- Fix aria-pressed -> aria-expanded + aria-haspopup on menu anchor triggers
- Add aria-label to username/password auth inputs

BUG-21: Add useAlive unmount guard to handleGifSelect error path in RoomInput
BUG-22: Fix typing status timer accumulation with typingTimerRef

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Lotus Bot
2026-05-20 21:26:18 -04:00
parent a77929de8b
commit 60c2c97ba6
10 changed files with 35 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/app/features/room/message/Message.tsx
+12 -6
View File
@@ -727,7 +727,7 @@ export type MessageProps = {
hour24Clock: boolean;
dateFormatString: string;
};
export const Message = as<'div', MessageProps>(
export const Message = React.memo(as<'div', MessageProps>(
(
{
className,
@@ -984,6 +984,7 @@ export const Message = as<'div', MessageProps>(
variant="SurfaceVariant"
size="300"
radii="300"
aria-label="Add reaction"
aria-pressed={!!emojiBoardAnchor}
>
<Icon src={Icons.SmilePlus} size="100" />
@@ -996,6 +997,7 @@ export const Message = as<'div', MessageProps>(
variant="SurfaceVariant"
size="300"
radii="300"
aria-label="Reply"
>
<Icon src={Icons.ReplyArrow} size="100" />
</IconButton>
@@ -1006,6 +1008,7 @@ export const Message = as<'div', MessageProps>(
variant="SurfaceVariant"
size="300"
radii="300"
aria-label="Reply in thread"
>
<Icon src={Icons.ThreadPlus} size="100" />
</IconButton>
@@ -1016,6 +1019,7 @@ export const Message = as<'div', MessageProps>(
variant="SurfaceVariant"
size="300"
radii="300"
aria-label="Edit message"
>
<Icon src={Icons.Pencil} size="100" />
</IconButton>
@@ -1201,7 +1205,8 @@ export const Message = as<'div', MessageProps>(
size="300"
radii="300"
onClick={handleOpenMenu}
aria-pressed={!!menuAnchor}
aria-expanded={!!menuAnchor}
aria-haspopup="menu"
>
<Icon src={Icons.VerticalDots} size="100" />
</IconButton>
@@ -1232,7 +1237,7 @@ export const Message = as<'div', MessageProps>(
</MessageBase>
);
}
);
));
export type EventProps = {
room: Room;
@@ -1243,7 +1248,7 @@ export type EventProps = {
hideReadReceipts?: boolean;
showDeveloperTools?: boolean;
};
export const Event = as<'div', EventProps>(
export const Event = React.memo(as<'div', EventProps>(
(
{
className,
@@ -1370,7 +1375,8 @@ export const Event = as<'div', EventProps>(
size="300"
radii="300"
onClick={handleOpenMenu}
aria-pressed={!!menuAnchor}
aria-expanded={!!menuAnchor}
aria-haspopup="menu"
>
<Icon src={Icons.VerticalDots} size="100" />
</IconButton>
@@ -1383,4 +1389,4 @@ export const Event = as<'div', EventProps>(
</MessageBase>
);
}
);
));