From 5130dfc9c8d425f76ef6e4dd9c78bcd19efd0b68 Mon Sep 17 00:00:00 2001 From: Lotus CI Date: Mon, 12 Oct 2026 15:27:01 -0400 Subject: [PATCH] fix(settings): "ENTER for Newline" stays per device (#348) Settings sync mirrored enterForNewline to io.lotus.settings, so turning it on for a phone keyboard switched the desktop to Ctrl+Enter-to-send (and vice versa). It is now in DEVICE_LOCAL_KEYS. Verified with one account on a phone and a desktop profile: toggling it on the phone leaves the desktop at Enter-to-send, and it is no longer in the synced account data. Fixes #348 Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_017PCb59uY3UKqDqt7B6hzd5 --- src/app/utils/settingsSync.test.ts | 6 ++++++ src/app/utils/settingsSync.ts | 3 +++ 2 files changed, 9 insertions(+) diff --git a/src/app/utils/settingsSync.test.ts b/src/app/utils/settingsSync.test.ts index 70c2b68c4..06f10a5d8 100644 --- a/src/app/utils/settingsSync.test.ts +++ b/src/app/utils/settingsSync.test.ts @@ -104,3 +104,9 @@ describe('buildSyncedContent', () => { assert.deepEqual(c.settings, pickSyncable(base)); }); }); + +describe('device-local keys', () => { + it('keeps enterForNewline on each device (#348)', () => { + assert.equal(DEVICE_LOCAL_KEYS.has('enterForNewline'), true); + }); +}); diff --git a/src/app/utils/settingsSync.ts b/src/app/utils/settingsSync.ts index 0a49d338b..205b24887 100644 --- a/src/app/utils/settingsSync.ts +++ b/src/app/utils/settingsSync.ts @@ -49,6 +49,9 @@ export const DEVICE_LOCAL_KEYS: ReadonlySet = new Set