feat(threads): Slack-style per-thread notifications (P4-1)
Default = Participating: thread replies notify only when you've posted in the thread or are @mentioned; per-thread override to All / Mentions-only / Mute via a bell menu in the thread panel header. Modes sync across devices in io.lotus.thread_notifications account data (pruned on write: left rooms, >180d, cap 200/room). Muted threads: no notifications/sounds, chip badge suppressed (+BellMute glyph), and their counts are subtracted from the room's sidebar badge (client-side; clamped ≥0). Also fixes the thread notification path itself: thread replies are now owned by exactly ONE handler (room-level ThreadEvent.NewReply via a new useRoomsListener hook, with per-thread dedupe, panel-aware focus suppression, and per-thread OS tag coalescing) — the existing RoomEvent.Timeline handlers in the notifier and the unread binder are explicitly thread-guarded, eliminating the previously un-gated/double path. Room badges now also refresh live on RoomEvent.UnreadNotifications (surgical per-room PUT; fixes thread-badge lag). Pure decision core shouldNotifyThreadReply (13-case matrix) + prune + unread subtraction: +32 tests (648 total). E2EE caveat documented: mentions-only may under-notify pre-decryption (same class as the existing path). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,127 @@
|
||||
import { Box, config, Icon, Icons, IconSrc, Menu, MenuItem, PopOut, RectCords, Text } from 'folds';
|
||||
import React, { MouseEventHandler, ReactNode, useMemo, useState } from 'react';
|
||||
import FocusTrap from 'focus-trap-react';
|
||||
import { stopPropagation } from '../utils/keyboard';
|
||||
import { ThreadNotificationMode } from '../utils/threadNotifications';
|
||||
import { useSetThreadNotificationMode } from '../hooks/useThreadNotifications';
|
||||
import { AsyncStatus } from '../hooks/useAsyncCallback';
|
||||
|
||||
export const getThreadNotificationModeIcon = (mode?: ThreadNotificationMode): IconSrc => {
|
||||
if (mode === ThreadNotificationMode.Mute) return Icons.BellMute;
|
||||
if (mode === ThreadNotificationMode.MentionsOnly) return Icons.BellPing;
|
||||
if (mode === ThreadNotificationMode.All) return Icons.BellRing;
|
||||
|
||||
return Icons.Bell;
|
||||
};
|
||||
|
||||
const useThreadNotificationModes = (): ThreadNotificationMode[] =>
|
||||
useMemo(
|
||||
() => [
|
||||
ThreadNotificationMode.Default,
|
||||
ThreadNotificationMode.All,
|
||||
ThreadNotificationMode.MentionsOnly,
|
||||
ThreadNotificationMode.Mute,
|
||||
],
|
||||
[],
|
||||
);
|
||||
|
||||
const useThreadNotificationModeStr = (): Record<ThreadNotificationMode, string> =>
|
||||
useMemo(
|
||||
() => ({
|
||||
[ThreadNotificationMode.Default]: 'Default (participating)',
|
||||
[ThreadNotificationMode.All]: 'All replies',
|
||||
[ThreadNotificationMode.MentionsOnly]: 'Mentions only',
|
||||
[ThreadNotificationMode.Mute]: 'Mute',
|
||||
}),
|
||||
[],
|
||||
);
|
||||
|
||||
type ThreadNotificationModeSwitcherProps = {
|
||||
roomId: string;
|
||||
threadId: string;
|
||||
value?: ThreadNotificationMode;
|
||||
children: (
|
||||
handleOpen: MouseEventHandler<HTMLButtonElement>,
|
||||
opened: boolean,
|
||||
changing: boolean,
|
||||
) => ReactNode;
|
||||
};
|
||||
export function ThreadNotificationModeSwitcher({
|
||||
roomId,
|
||||
threadId,
|
||||
value = ThreadNotificationMode.Default,
|
||||
children,
|
||||
}: ThreadNotificationModeSwitcherProps) {
|
||||
const modes = useThreadNotificationModes();
|
||||
const modeToStr = useThreadNotificationModeStr();
|
||||
|
||||
const { modeState, setMode } = useSetThreadNotificationMode(roomId, threadId);
|
||||
const changing = modeState.status === AsyncStatus.Loading;
|
||||
|
||||
const [menuCords, setMenuCords] = useState<RectCords>();
|
||||
|
||||
const handleOpenMenu: MouseEventHandler<HTMLButtonElement> = (evt) => {
|
||||
setMenuCords(evt.currentTarget.getBoundingClientRect());
|
||||
};
|
||||
|
||||
const handleClose = () => {
|
||||
setMenuCords(undefined);
|
||||
};
|
||||
|
||||
const handleSelect = (mode: ThreadNotificationMode) => {
|
||||
if (changing) return;
|
||||
setMode(mode);
|
||||
handleClose();
|
||||
};
|
||||
|
||||
return (
|
||||
<PopOut
|
||||
anchor={menuCords}
|
||||
offset={5}
|
||||
position="Bottom"
|
||||
align="End"
|
||||
content={
|
||||
<FocusTrap
|
||||
focusTrapOptions={{
|
||||
initialFocus: false,
|
||||
onDeactivate: handleClose,
|
||||
clickOutsideDeactivates: true,
|
||||
isKeyForward: (evt: KeyboardEvent) =>
|
||||
evt.key === 'ArrowDown' || evt.key === 'ArrowRight',
|
||||
isKeyBackward: (evt: KeyboardEvent) => evt.key === 'ArrowUp' || evt.key === 'ArrowLeft',
|
||||
escapeDeactivates: stopPropagation,
|
||||
}}
|
||||
>
|
||||
<Menu>
|
||||
<Box direction="Column" gap="100" style={{ padding: config.space.S100 }}>
|
||||
{modes.map((mode) => (
|
||||
<MenuItem
|
||||
key={mode}
|
||||
size="300"
|
||||
variant="Surface"
|
||||
aria-pressed={mode === value}
|
||||
radii="300"
|
||||
disabled={changing}
|
||||
onClick={() => handleSelect(mode)}
|
||||
before={
|
||||
<Icon
|
||||
size="100"
|
||||
src={getThreadNotificationModeIcon(mode)}
|
||||
filled={mode === value}
|
||||
/>
|
||||
}
|
||||
>
|
||||
<Text size="T300">
|
||||
{mode === value ? <b>{modeToStr[mode]}</b> : modeToStr[mode]}
|
||||
</Text>
|
||||
</MenuItem>
|
||||
))}
|
||||
</Box>
|
||||
</Menu>
|
||||
</FocusTrap>
|
||||
}
|
||||
>
|
||||
{children(handleOpenMenu, !!menuCords, changing)}
|
||||
</PopOut>
|
||||
);
|
||||
}
|
||||
Reference in New Issue
Block a user