fix(a11y): review-wave fixes (P3-4)
- `?` shortcut now stopImmediatePropagation so RoomView's type-to-focus handler
doesn't steal focus into the composer behind the dialog (and swallow Escape) —
CONFIRMED review finding.
- Typing live region stays mounted (empty when idle) so the FIRST "X is typing"
is reliably announced (a status region added with its text isn't always read).
- Removed a stray empty `{}` JSX expression in MediaGallery (leftover from an
auto-fix).
Reviewer verified the rest: collapsed-message labels, focus-return
classification (4 dialogs fixed, popouts correctly left), and all aria fixes.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
@@ -261,7 +261,6 @@ function Lightbox({
|
|||||||
escapeDeactivates: false,
|
escapeDeactivates: false,
|
||||||
}}
|
}}
|
||||||
>
|
>
|
||||||
{}
|
|
||||||
<div
|
<div
|
||||||
role="dialog"
|
role="dialog"
|
||||||
aria-modal
|
aria-modal
|
||||||
|
|||||||
@@ -33,11 +33,10 @@ export const RoomViewTyping = as<'div', RoomViewTypingProps>(
|
|||||||
[typingMembers, myUserId, room],
|
[typingMembers, myUserId, room],
|
||||||
);
|
);
|
||||||
|
|
||||||
if (typingNames.length === 0) {
|
|
||||||
return null;
|
|
||||||
}
|
|
||||||
|
|
||||||
// A single, non-truncated string for assistive technology to announce.
|
// A single, non-truncated string for assistive technology to announce.
|
||||||
|
// Computed even when empty so the live region can stay mounted (below) —
|
||||||
|
// a `role="status"` region added to the DOM together with its first text
|
||||||
|
// is not reliably announced by some screen readers.
|
||||||
let typingAnnouncement = '';
|
let typingAnnouncement = '';
|
||||||
if (typingNames.length === 1) {
|
if (typingNames.length === 1) {
|
||||||
typingAnnouncement = `${typingNames[0]} is typing`;
|
typingAnnouncement = `${typingNames[0]} is typing`;
|
||||||
@@ -65,9 +64,11 @@ export const RoomViewTyping = as<'div', RoomViewTypingProps>(
|
|||||||
|
|
||||||
return (
|
return (
|
||||||
<div style={{ position: 'relative' }}>
|
<div style={{ position: 'relative' }}>
|
||||||
|
{/* Persistently mounted so the FIRST "X is typing" is announced. */}
|
||||||
<span className={css.SrOnly} role="status" aria-live="polite" aria-atomic="true">
|
<span className={css.SrOnly} role="status" aria-live="polite" aria-atomic="true">
|
||||||
{typingAnnouncement}
|
{typingAnnouncement}
|
||||||
</span>
|
</span>
|
||||||
|
{typingNames.length > 0 && (
|
||||||
<Box
|
<Box
|
||||||
className={classNames(css.RoomViewTyping, className)}
|
className={classNames(css.RoomViewTyping, className)}
|
||||||
alignItems="Center"
|
alignItems="Center"
|
||||||
@@ -144,6 +145,7 @@ export const RoomViewTyping = as<'div', RoomViewTypingProps>(
|
|||||||
<Icon size="50" src={Icons.Cross} />
|
<Icon size="50" src={Icons.Cross} />
|
||||||
</IconButton>
|
</IconButton>
|
||||||
</Box>
|
</Box>
|
||||||
|
)}
|
||||||
</div>
|
</div>
|
||||||
);
|
);
|
||||||
},
|
},
|
||||||
|
|||||||
@@ -55,6 +55,10 @@ export function useKeyboardShortcutsTrigger() {
|
|||||||
// `?` is produced by Shift + `/` on the common layouts.
|
// `?` is produced by Shift + `/` on the common layouts.
|
||||||
if (evt.key === '?') {
|
if (evt.key === '?') {
|
||||||
evt.preventDefault();
|
evt.preventDefault();
|
||||||
|
// Stop RoomView's window-level "type any char → focus composer"
|
||||||
|
// handler from also firing — otherwise focus lands in the composer
|
||||||
|
// behind the dialog and Escape gets swallowed by the contenteditable.
|
||||||
|
evt.stopImmediatePropagation();
|
||||||
setOpen(true);
|
setOpen(true);
|
||||||
}
|
}
|
||||||
},
|
},
|
||||||
|
|||||||
Reference in New Issue
Block a user