fix(widgets): room widgets render again (bypass broken isValidUrl)
matrix-widget-api 1.17.0's WidgetParser rejects every URL (it compares URL.protocol "https:" to "https"), so the widgets panel was always empty. Build Widget objects from the raw state events with a correct scheme check plus the existing origin check. Unit-tested against a real state event. Fixes #15 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PPmy3tPq869XDW4njjVaKA
This commit is contained in:
@@ -1,21 +1,67 @@
|
||||
import { Room } from 'matrix-js-sdk';
|
||||
import { Room, MatrixEvent } from 'matrix-js-sdk';
|
||||
import { useMemo } from 'react';
|
||||
import { Widget, WidgetParser, IStateEvent } from 'matrix-widget-api';
|
||||
import { Widget } from 'matrix-widget-api';
|
||||
import { StateEvent } from '../../../../types/matrix/room';
|
||||
import { useRoomState } from '../../../hooks/useRoomState';
|
||||
import { StateKeyToEvents, useRoomState } from '../../../hooks/useRoomState';
|
||||
import { isWidgetUrlSafe } from './widgetUtils';
|
||||
|
||||
/**
|
||||
* Builds the `Widget` list from raw `im.vector.modular.widgets` state events.
|
||||
*
|
||||
* NOTE: we do NOT use `WidgetParser.parseWidgetsFromRoomState` here. In
|
||||
* matrix-widget-api 1.17.0 its `isValidUrl` compares `URL.protocol` (which is
|
||||
* always colon-suffixed, e.g. "https:") against the bare strings "http"/
|
||||
* "https", so it rejects every URL and the parser always returns []. We build
|
||||
* the `Widget`s ourselves with a correct scheme check plus the existing
|
||||
* `isWidgetUrlSafe` origin check.
|
||||
*/
|
||||
export const widgetsFromStateEvents = (
|
||||
widgetEvents: StateKeyToEvents | undefined,
|
||||
appOrigin: string,
|
||||
): Widget[] => {
|
||||
if (!widgetEvents) return [];
|
||||
const widgets: Widget[] = [];
|
||||
Array.from(widgetEvents.values()).forEach((event: MatrixEvent) => {
|
||||
const content = event.getContent();
|
||||
// Removed widgets are represented as an empty content state event.
|
||||
if (!content || Object.keys(content).length === 0) return;
|
||||
|
||||
const id = event.getStateKey();
|
||||
const { type, url, name, data, waitForIframeLoad } = content;
|
||||
const creatorUserId = content.creatorUserId || event.getSender();
|
||||
if (!id || !type || !url || !creatorUserId) return;
|
||||
|
||||
let scheme: string;
|
||||
try {
|
||||
scheme = new URL(url).protocol;
|
||||
} catch {
|
||||
return;
|
||||
}
|
||||
if (scheme !== 'https:') return;
|
||||
if (!isWidgetUrlSafe(url, appOrigin)) return;
|
||||
|
||||
widgets.push(
|
||||
new Widget({
|
||||
id,
|
||||
creatorUserId,
|
||||
type,
|
||||
url,
|
||||
name,
|
||||
data,
|
||||
waitForIframeLoad,
|
||||
}),
|
||||
);
|
||||
});
|
||||
return widgets;
|
||||
};
|
||||
|
||||
/**
|
||||
* All valid `im.vector.modular.widgets` room widgets, reactive on room state.
|
||||
* `WidgetParser` drops empty/removed (`{}`) and malformed entries.
|
||||
*/
|
||||
export const useRoomWidgets = (room: Room): Widget[] => {
|
||||
const state = useRoomState(room);
|
||||
return useMemo(() => {
|
||||
const widgetEvents = state.get(StateEvent.Widget);
|
||||
if (!widgetEvents) return [];
|
||||
const stateEvents = Array.from(widgetEvents.values()).map(
|
||||
(event) => event.getEffectiveEvent() as unknown as IStateEvent,
|
||||
);
|
||||
return WidgetParser.parseWidgetsFromRoomState(stateEvents);
|
||||
}, [state]);
|
||||
return useMemo(
|
||||
() => widgetsFromStateEvents(state.get(StateEvent.Widget), window.location.origin),
|
||||
[state],
|
||||
);
|
||||
};
|
||||
|
||||
Reference in New Issue
Block a user