From 23e264d1798314f49674c1c7feb2cc8717fc84fb Mon Sep 17 00:00:00 2001 From: Jared Vititoe Date: Fri, 10 Jul 2026 15:40:39 -0400 Subject: [PATCH] fix(bookmarks): drop unused senderId from stored bookmark Review noted the 500-entry io.lotus.bookmarks blob approaches the ~65KB event limit. The senderId I stored was never read back (the panel re-resolves the live sender via the event and uses the senderName snapshot otherwise), so it was dead payload. Keep only senderName. Co-Authored-By: Claude Opus 4.8 --- src/app/features/room/message/Message.tsx | 1 - src/app/hooks/useBookmarks.ts | 9 +++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/app/features/room/message/Message.tsx b/src/app/features/room/message/Message.tsx index 49925cfdb..fca7d7449 100644 --- a/src/app/features/room/message/Message.tsx +++ b/src/app/features/room/message/Message.tsx @@ -1190,7 +1190,6 @@ export const Message = React.memo( savedAt: Date.now(), previewText: body.slice(0, 120), roomName: room.name, - senderId, senderName: senderDisplayName, }); } diff --git a/src/app/hooks/useBookmarks.ts b/src/app/hooks/useBookmarks.ts index db8689687..0e3f319b8 100644 --- a/src/app/hooks/useBookmarks.ts +++ b/src/app/hooks/useBookmarks.ts @@ -8,10 +8,11 @@ export type Bookmark = { savedAt: number; previewText: string; roomName: string; - // Author of the saved message. Optional for backward compatibility with - // bookmarks stored before attribution was added; the panel resolves a live - // name when the room is joined and falls back to these snapshots otherwise. - senderId?: string; + // Author display name, snapshotted at save time. Optional for backward + // compatibility with bookmarks stored before attribution was added; the panel + // re-resolves a live name when the room is joined and falls back to this + // snapshot otherwise. (We deliberately don't store the sender MXID — it's never + // read back and would only grow the 500-entry account-data blob.) senderName?: string; };