Merge pull request 'Status banner from Kuma: statusPages config (cinny #124)' (#29) from desktop-status-banner into main

Merge pull request #29: status banner config (cinny #124)

config.json

@@ -24,5 +24,16 @@
     "basename": "/"
   },
   "gifApiKey": "",
-  "webAppUrl": "https://chat.lotusguild.org"
+  "webAppUrl": "https://chat.lotusguild.org",
+  "statusPages": {
+    "matrix.lotusguild.org": {
+      "url": "https://isitup.lotusguild.org",
+      "slug": "matrix",
+      "groups": {
+        "homeserver": "Homeserver",
+        "calls": "Voice calls",
+        "login": "Login"
+      }
+    }
+  }
 }

src-tauri/src/lib.rs

@@ -13,8 +13,6 @@ use tauri_plugin_opener::OpenerExt;
 
 pub mod gpu_workarounds;
 mod native;
-#[cfg(any(target_os = "linux", target_os = "windows", test))]
-mod webview_permissions;
 
 /// Bring the main window to the foreground from the tray / a hidden /
 /// minimized state. Shared by the tray, single-instance, and deep-link paths.
@@ -1223,76 +1221,41 @@ pub fn run() {
                 let _ = window_vibrancy::apply_mica(&window, Some(true));
             }
 
-            // cinny-desktop #22: the app's own page gets the microphone, camera
-            // and notifications without a prompt; other origins (room widgets,
-            // link-preview embeds) are refused them. See webview_permissions.
-            #[cfg(any(target_os = "linux", target_os = "windows"))]
-            let app_origins = webview_permissions::AppOrigins::new(
-                port,
-                app.config().build.dev_url.as_ref(),
-            );
-
+            // Auto-grant camera, microphone, and notification permissions in WebView2.
             #[cfg(target_os = "windows")]
-            window.with_webview({
-                let app_origins = app_origins.clone();
-                move |webview| {
-                    use webview2_com::{
-                        Microsoft::Web::WebView2::Win32::{
-                            COREWEBVIEW2_PERMISSION_KIND,
-                            COREWEBVIEW2_PERMISSION_KIND_CAMERA,
-                            COREWEBVIEW2_PERMISSION_KIND_GEOLOCATION,
-                            COREWEBVIEW2_PERMISSION_KIND_MICROPHONE,
-                            COREWEBVIEW2_PERMISSION_KIND_NOTIFICATIONS,
-                            COREWEBVIEW2_PERMISSION_STATE_ALLOW,
-                            COREWEBVIEW2_PERMISSION_STATE_DENY,
-                        },
-                        PermissionRequestedEventHandler,
-                    };
-                    use webview_permissions::{decide, Decision, Kind, WINDOWS_GRANTS};
+            window.with_webview(|webview| {
+                use webview2_com::{
+                    Microsoft::Web::WebView2::Win32::{
+                        COREWEBVIEW2_PERMISSION_KIND,
+                        COREWEBVIEW2_PERMISSION_KIND_CAMERA,
+                        COREWEBVIEW2_PERMISSION_KIND_MICROPHONE,
+                        COREWEBVIEW2_PERMISSION_KIND_NOTIFICATIONS,
+                        COREWEBVIEW2_PERMISSION_STATE_ALLOW,
+                    },
+                    PermissionRequestedEventHandler,
+                };
 
-                    let controller = webview.controller();
-                    if let Ok(core) = unsafe { controller.CoreWebView2() } {
-                        let handler = PermissionRequestedEventHandler::create(Box::new(
-                            move |_sender, args| {
-                                if let Some(args) = args {
-                                    let mut raw = COREWEBVIEW2_PERMISSION_KIND(0);
-                                    unsafe { args.PermissionKind(&mut raw) }?;
-                                    let kind = if raw == COREWEBVIEW2_PERMISSION_KIND_MICROPHONE
-                                        || raw == COREWEBVIEW2_PERMISSION_KIND_CAMERA
-                                    {
-                                        Kind::Media
-                                    } else if raw == COREWEBVIEW2_PERMISSION_KIND_NOTIFICATIONS {
-                                        Kind::Notifications
-                                    } else if raw == COREWEBVIEW2_PERMISSION_KIND_GEOLOCATION {
-                                        Kind::Geolocation
-                                    } else {
-                                        Kind::Other
-                                    };
-                                    // The origin of the frame that asked.
-                                    let mut uri = windows::core::PWSTR::null();
-                                    unsafe { args.Uri(&mut uri) }?;
-                                    let uri = webview2_com::take_pwstr(uri);
-                                    match decide(kind, &uri, &app_origins, WINDOWS_GRANTS) {
-                                        Decision::Allow => unsafe {
-                                            args.SetState(COREWEBVIEW2_PERMISSION_STATE_ALLOW)
-                                        }?,
-                                        Decision::Deny => {
-                                            eprintln!(
-                                                "webview: denied {kind:?} permission to {uri}"
-                                            );
-                                            unsafe {
-                                                args.SetState(COREWEBVIEW2_PERMISSION_STATE_DENY)
-                                            }?
-                                        }
-                                        Decision::Default => {}
-                                    }
+                let controller = webview.controller();
+                if let Ok(core) = unsafe { controller.CoreWebView2() } {
+                    let handler = PermissionRequestedEventHandler::create(Box::new(
+                        |_sender, args| {
+                            if let Some(args) = args {
+                                let mut kind = COREWEBVIEW2_PERMISSION_KIND(0);
+                                unsafe { args.PermissionKind(&mut kind) }?;
+                                if kind == COREWEBVIEW2_PERMISSION_KIND_MICROPHONE
+                                    || kind == COREWEBVIEW2_PERMISSION_KIND_CAMERA
+                                    || kind == COREWEBVIEW2_PERMISSION_KIND_NOTIFICATIONS
+                                {
+                                    unsafe {
+                                        args.SetState(COREWEBVIEW2_PERMISSION_STATE_ALLOW)
+                                    }?;
                                 }
-                                Ok(())
-                            },
-                        ));
-                        let mut token = Default::default();
-                        let _ = unsafe { core.add_PermissionRequested(&handler, &mut token) };
-                    }
+                            }
+                            Ok(())
+                        },
+                    ));
+                    let mut token = Default::default();
+                    let _ = unsafe { core.add_PermissionRequested(&handler, &mut token) };
                 }
             })?;
 
@@ -1300,48 +1263,19 @@ pub fn run() {
             // default (unlike WebView2/WKWebView), which leaves
             // `navigator.mediaDevices` undefined and makes Element Call
             // report "browser does not support WebRTC". Turn them on and
-            // answer the permission requests, mirroring the WebView2 handling
-            // above. WebKitGTK doesn't say which frame asked, so the origin
-            // checked is the page in the window (see webview_permissions).
+            // auto-grant the resulting camera/mic permission prompt, mirroring
+            // the WebView2 handling above.
             #[cfg(target_os = "linux")]
-            window.with_webview(move |webview| {
-                use webkit2gtk::glib::prelude::ObjectExt;
-                use webkit2gtk::{
-                    DeviceInfoPermissionRequest, GeolocationPermissionRequest,
-                    NotificationPermissionRequest, PermissionRequestExt, SettingsExt,
-                    UserMediaPermissionRequest, WebViewExt,
-                };
-                use webview_permissions::{decide, Decision, Kind, LINUX_GRANTS};
+            window.with_webview(|webview| {
+                use webkit2gtk::{PermissionRequestExt, SettingsExt, WebViewExt};
 
                 let wv = webview.inner();
                 if let Some(settings) = WebViewExt::settings(&wv) {
                     settings.set_enable_media_stream(true);
                     settings.set_enable_webrtc(true);
                 }
-                wv.connect_permission_request(move |wv, request| {
-                    let kind = if request.is::<UserMediaPermissionRequest>() {
-                        Kind::Media
-                    } else if request.is::<DeviceInfoPermissionRequest>() {
-                        Kind::DeviceInfo
-                    } else if request.is::<NotificationPermissionRequest>() {
-                        Kind::Notifications
-                    } else if request.is::<GeolocationPermissionRequest>() {
-                        Kind::Geolocation
-                    } else {
-                        Kind::Other
-                    };
-                    let uri = wv.uri().map(|u| u.to_string()).unwrap_or_default();
-                    match decide(kind, &uri, &app_origins, LINUX_GRANTS) {
-                        Decision::Allow => request.allow(),
-                        // No prompt of our own: anything not granted is denied.
-                        Decision::Deny | Decision::Default => {
-                            eprintln!(
-                                "webview: denied {} to {uri}",
-                                request.type_().name()
-                            );
-                            request.deny();
-                        }
-                    }
+                wv.connect_permission_request(|_webview, request| {
+                    request.allow();
                     true
                 });
             })?;

src-tauri/src/webview_permissions.rs

@@ -1,221 +0,0 @@
-//! Which WebView permission requests the app grants (cinny-desktop #22).
-//!
-//! The web client asks for the microphone/camera/screen (calls, voice
-//! messages), the device list (audio-output picker), notifications and the
-//! location (location sharing). Those are granted without a prompt, but only
-//! to the app's own origin. Everything else is left alone (Windows: WebView2's
-//! own prompt) or denied (Linux: WebKitGTK has no prompt of its own).
-//!
-//! What "the requesting origin" means differs per engine:
-//! - WebView2 reports the origin of the frame that asked (`args.Uri()`), so a
-//!   room widget or link-preview embed is refused here.
-//! - WebKitGTK doesn't say which frame asked; the check is on the page loaded
-//!   in the window. Frames are gated before the request gets this far by the
-//!   Permissions Policy: cinny only puts `microphone; camera` in the `allow=`
-//!   of the call frame (same origin on desktop), and cross-origin frames get
-//!   neither location nor notifications.
-
-use tauri::Url;
-
-/// A permission request, reduced to what the policy cares about.
-#[derive(Clone, Copy, Debug, PartialEq, Eq)]
-pub(crate) enum Kind {
-    /// Microphone, camera or screen capture (getUserMedia/getDisplayMedia).
-    Media,
-    /// Device labels/ids from enumerateDevices (WebKitGTK only).
-    #[cfg_attr(not(target_os = "linux"), allow(dead_code))]
-    DeviceInfo,
-    Notifications,
-    Geolocation,
-    /// Anything else: clipboard read, storage access, pointer lock, DRM, …
-    Other,
-}
-
-#[derive(Clone, Copy, Debug, PartialEq, Eq)]
-pub(crate) enum Decision {
-    Allow,
-    Deny,
-    /// Let the engine decide (WebView2 prompts; WebKitGTK denies).
-    Default,
-}
-
-/// What the Linux (WebKitGTK) handler grants to the app.
-#[cfg_attr(not(target_os = "linux"), allow(dead_code))]
-pub(crate) const LINUX_GRANTS: &[Kind] = &[
-    Kind::Media,
-    Kind::DeviceInfo,
-    Kind::Notifications,
-    Kind::Geolocation,
-];
-/// What the Windows (WebView2) handler grants to the app. Location keeps
-/// WebView2's own prompt, as before.
-#[cfg_attr(not(target_os = "windows"), allow(dead_code))]
-pub(crate) const WINDOWS_GRANTS: &[Kind] = &[Kind::Media, Kind::Notifications];
-
-/// The decision for a request of `kind` from `uri`.
-pub(crate) fn decide(kind: Kind, uri: &str, app: &AppOrigins, grants: &[Kind]) -> Decision {
-    if kind == Kind::Other {
-        return Decision::Default;
-    }
-    if !app.contains(uri) {
-        return Decision::Deny;
-    }
-    if grants.contains(&kind) {
-        Decision::Allow
-    } else {
-        Decision::Default
-    }
-}
-
-/// scheme, host, port (explicit or the scheme's default).
-type Origin = (String, String, Option<u16>);
-
-fn origin_of(uri: &str) -> Option<Origin> {
-    let url = Url::parse(uri).ok()?;
-    let host = url.host_str()?.to_ascii_lowercase();
-    Some((url.scheme().to_owned(), host, url.port_or_known_default()))
-}
-
-/// The origins the app's own page is served from.
-#[derive(Clone, Debug)]
-pub(crate) struct AppOrigins(Vec<Origin>);
-
-impl AppOrigins {
-    /// Release builds load `http://localhost:{port}` (tauri-plugin-localhost).
-    /// Debug builds load the bundled page (`tauri://localhost`, or
-    /// `http://tauri.localhost` on Windows) or, under `tauri dev`, `dev_url`.
-    pub(crate) fn new(port: u16, dev_url: Option<&Url>) -> Self {
-        let mut uris = vec![format!("http://localhost:{port}/")];
-        if cfg!(debug_assertions) {
-            uris.push("tauri://localhost/".into());
-            uris.push("http://tauri.localhost/".into());
-            if let Some(dev) = dev_url {
-                uris.push(dev.to_string());
-            }
-        }
-        Self(uris.iter().filter_map(|u| origin_of(u)).collect())
-    }
-
-    pub(crate) fn contains(&self, uri: &str) -> bool {
-        origin_of(uri).is_some_and(|o| self.0.contains(&o))
-    }
-}
-
-#[cfg(test)]
-mod tests {
-    use super::*;
-
-    fn app() -> AppOrigins {
-        AppOrigins::new(44548, None)
-    }
-
-    #[test]
-    fn app_origin_matches_only_the_app() {
-        let app = app();
-        assert!(app.contains("http://localhost:44548/"));
-        assert!(app.contains("http://localhost:44548/#/home/!room:server"));
-        assert!(app.contains("http://LOCALHOST:44548/public/element-call/index.html"));
-        for other in [
-            "http://localhost:44549/",
-            "https://localhost:44548/",
-            "http://127.0.0.1:44548/",
-            "http://localhost/",
-            "http://localhost.evil.example:44548/",
-            "http://evil.example/?http://localhost:44548/",
-            "https://www.youtube-nocookie.com/embed/x",
-            "https://chat.lotusguild.org/",
-            "about:blank",
-            "data:text/html,hi",
-            "null",
-            "",
-        ] {
-            assert!(!app.contains(other), "{other}");
-        }
-    }
-
-    #[test]
-    fn debug_builds_also_accept_the_bundled_and_dev_pages() {
-        let dev = Url::parse("http://localhost:8080").unwrap();
-        let app = AppOrigins::new(44548, Some(&dev));
-        assert_eq!(
-            app.contains("tauri://localhost/index.html"),
-            cfg!(debug_assertions)
-        );
-        assert_eq!(
-            app.contains("http://tauri.localhost/"),
-            cfg!(debug_assertions)
-        );
-        assert_eq!(
-            app.contains("http://localhost:8080/"),
-            cfg!(debug_assertions)
-        );
-        assert!(app.contains("http://localhost:44548/"));
-        assert!(!app.contains("tauri://evil/"));
-    }
-
-    #[test]
-    fn app_gets_its_grants_without_a_prompt() {
-        let app = app();
-        let uri = "http://localhost:44548/";
-        for kind in [
-            Kind::Media,
-            Kind::DeviceInfo,
-            Kind::Notifications,
-            Kind::Geolocation,
-        ] {
-            assert_eq!(
-                decide(kind, uri, &app, LINUX_GRANTS),
-                Decision::Allow,
-                "{kind:?}"
-            );
-        }
-        assert_eq!(
-            decide(Kind::Media, uri, &app, WINDOWS_GRANTS),
-            Decision::Allow
-        );
-        assert_eq!(
-            decide(Kind::Notifications, uri, &app, WINDOWS_GRANTS),
-            Decision::Allow
-        );
-        // Location on Windows keeps WebView2's prompt.
-        assert_eq!(
-            decide(Kind::Geolocation, uri, &app, WINDOWS_GRANTS),
-            Decision::Default
-        );
-    }
-
-    #[test]
-    fn other_origins_are_refused() {
-        let app = app();
-        for uri in [
-            "https://widget.example/",
-            "https://www.youtube-nocookie.com/embed/x",
-            "",
-        ] {
-            for kind in [
-                Kind::Media,
-                Kind::DeviceInfo,
-                Kind::Notifications,
-                Kind::Geolocation,
-            ] {
-                assert_eq!(decide(kind, uri, &app, LINUX_GRANTS), Decision::Deny);
-                assert_eq!(decide(kind, uri, &app, WINDOWS_GRANTS), Decision::Deny);
-            }
-        }
-    }
-
-    #[test]
-    fn other_kinds_are_left_to_the_engine() {
-        let app = app();
-        for uri in ["http://localhost:44548/", "https://widget.example/"] {
-            assert_eq!(
-                decide(Kind::Other, uri, &app, LINUX_GRANTS),
-                Decision::Default
-            );
-            assert_eq!(
-                decide(Kind::Other, uri, &app, WINDOWS_GRANTS),
-                Decision::Default
-            );
-        }
-    }
-}